chrome/browser/resources/settings/internet_page/network_summary_item.js - Issue 2578793004: MD Settings: Fix size and padding of expand button

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/internet_page/network_summary_item.js

Issue 2578793004: MD Settings: Fix size and padding of expand button (Closed)

Patch Set: Rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html ('K') | « chrome/browser/resources/settings/internet_page/network_summary_item.html ('k') | chrome/browser/resources/settings/settings_shared_css.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/internet_page/network_summary_item.js

diff --git a/chrome/browser/resources/settings/internet_page/network_summary_item.js b/chrome/browser/resources/settings/internet_page/network_summary_item.js

index f32e01518270ded3587d2ca681edcdc71c58411b..144968d882d31a540a835f08b8d7dfca747956e0 100644

--- a/chrome/browser/resources/settings/internet_page/network_summary_item.js

+++ b/chrome/browser/resources/settings/internet_page/network_summary_item.js

@@ -75,10 +75,6 @@ Polymer({

- keyBindings: {

- 'enter': 'onDetailsTap_',

- },

dschuyler 2016/12/16 22:41:41 It's not clear to me why this is being removed. Is

stevenjb 2016/12/16 22:56:10 It's unwanted and is actually causing the button t

dschuyler 2016/12/17 01:13:54 It's good. I just wanted to ask in case it was a w

/** @private */

expandedChanged_: function() {

var type = this.deviceState ? this.deviceState.Type : '';