Move MediaStreamTrack contentHint to separate IDL.

Move MediaStreamTrack contentHint to separate IDL.

BUG=chromium:653531
R=esprehn@chromium.org, mcasas@chromium.org

Committed: https://crrev.com/1d43319164d27261a4e15df9e7b78b5700754f6a
Cr-Commit-Position: refs/heads/master@{#438603}

[pbos, 2016-12-14 15:46:47]

PTAL

[pbos, 2016-12-14 15:52:55]

move idl entry to partial interfaces

[pbos, 2016-12-14 15:55:18]

Description was changed from

==========
Move MST contentHint to partial-interface IDL.

BUG=chromium:653531
R=esprehn@chromium.org, mcasas@chromium.org
==========

to

==========
Move MediaStreamTrack contentHint to separate IDL.

BUG=chromium:653531
R=esprehn@chromium.org, mcasas@chromium.org
==========

[pbos, 2016-12-14 16:29:37]

add MediaStreamContentHint definition files

[pbos, 2016-12-14 16:29:48]

The CQ bit was checked by pbos@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 16:30:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[esprehn, 2016-12-14 16:44:31]

What's the benefit of this? It just proxies methods that exist on the real
interface.

[pbos, 2016-12-14 16:53:21]

On 2016/12/14 16:44:31, esprehn wrote:
> What's the benefit of this? It just proxies methods that exist on the real
> interface.

Told by mcasas@ to do this because it was a partial interface, perhaps you can
duke it out. I don't care either way. I guess the IDL maps closer to how the
spec files look or something. :)

https://bugs.chromium.org/p/chromium/issues/detail?id=653531#c9

[esprehn, 2016-12-14 17:35:16]

lgtm

I'd just put a comment and a link in the MediaStreamTrack.idl file, these proxy
methods don't seem like they add any value to me. That said I'll defer to
mcasas@ on this, since it's bike shedding either way here.

[mcasas, 2016-12-14 17:38:01]

lgtm

I asked to separate the interface in an .idl because
contentHint is a partial interface, with its own 
RuntimeEnabled flag and coming from its own
WICG spec (that is e.g., not mentioned now in 
MSTrack.idl). MSTrack Spec will become CR soon
and then we'd have all kinds of methods inside the
idl in different stages of specification.

https://codereview.chromium.org/2578623002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/mediastream/MediaStreamTrackContentHint.h
(right):

https://codereview.chromium.org/2578623002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediastream/MediaStreamTrackContentHint.h:17:
static void setContentHint(MediaStreamTrack&, const String&);
Since these two methods' implementations are
tiny and this header is of limited use to 
Source/modules/mediastream/, you could 
consider inlining their bodies.

[pbos, 2016-12-14 18:18:13]

inline contenthint method calls

[pbos, 2016-12-14 18:18:52]

https://codereview.chromium.org/2578623002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/mediastream/MediaStreamTrackContentHint.h
(right):

https://codereview.chromium.org/2578623002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediastream/MediaStreamTrackContentHint.h:17:
static void setContentHint(MediaStreamTrack&, const String&);
On 2016/12/14 17:38:01, mcasas wrote:
> Since these two methods' implementations are
> tiny and this header is of limited use to 
> Source/modules/mediastream/, you could 
> consider inlining their bodies.

Done, I misremembered that I should out-of-line them but that's for virtual
methods.

[pbos, 2016-12-14 18:18:59]

The CQ bit was checked by pbos@chromium.org

[pbos, 2016-12-14 18:19:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
esprehn@chromium.org, mcasas@chromium.org
Link to the patchset: https://codereview.chromium.org/2578623002/#ps60001
(title: "inline contenthint method calls")

[commit-bot: I haz the power, 2016-12-14 18:19:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 20:06:32]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481739539973780,
"parent_rev": "8a36d1462570afd4c4180c33783b57f31dbe386b", "commit_rev":
"46b59fbf2751b69ecab2d717bb3172eefdffbce5"}

[commit-bot: I haz the power, 2016-12-14 20:07:00]

Description was changed from

==========
Move MediaStreamTrack contentHint to separate IDL.

BUG=chromium:653531
R=esprehn@chromium.org, mcasas@chromium.org
==========

to

==========
Move MediaStreamTrack contentHint to separate IDL.

BUG=chromium:653531
R=esprehn@chromium.org, mcasas@chromium.org

Review-Url: https://codereview.chromium.org/2578623002
==========

[commit-bot: I haz the power, 2016-12-14 20:07:01]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-14 20:08:30]

Description was changed from

==========
Move MediaStreamTrack contentHint to separate IDL.

BUG=chromium:653531
R=esprehn@chromium.org, mcasas@chromium.org

Review-Url: https://codereview.chromium.org/2578623002
==========

to

==========
Move MediaStreamTrack contentHint to separate IDL.

BUG=chromium:653531
R=esprehn@chromium.org, mcasas@chromium.org

Committed: https://crrev.com/1d43319164d27261a4e15df9e7b78b5700754f6a
Cr-Commit-Position: refs/heads/master@{#438603}
==========

[commit-bot: I haz the power, 2016-12-14 20:08:31]

Patchset 4 (id:??) landed as
https://crrev.com/1d43319164d27261a4e15df9e7b78b5700754f6a
Cr-Commit-Position: refs/heads/master@{#438603}