third_party/WebKit/Source/modules/mediastream/MediaStreamTrackContentHint.h - Issue 2578623002: Move MediaStreamTrack contentHint to separate IDL.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/mediastream/MediaStreamTrackContentHint.h

Issue 2578623002: Move MediaStreamTrack contentHint to separate IDL. (Closed)

Patch Set: add MediaStreamContentHint definition files Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef MediaStreamTrackContentHint_h

	6 #define MediaStreamTrackContentHint_h

	7

	8 #include "wtf/Forward.h"

	9

	10 namespace blink {

	11

	12 class MediaStreamTrack;

	13

	14 class MediaStreamTrackContentHint final {

	15 public:

	16 static String contentHint(const MediaStreamTrack&);

	17 static void setContentHint(MediaStreamTrack&, const String&);
	mcasas 2016/12/14 17:38:01 Since these two methods' implementations are tiny Since these two methods' implementations are tiny and this header is of limited use to Source/modules/mediastream/, you could consider inlining their bodies. pbos 2016/12/14 18:18:52 Done, I misremembered that I should out-of-line th Show quoted text On 2016/12/14 17:38:01, mcasas wrote: > Since these two methods' implementations are > tiny and this header is of limited use to > Source/modules/mediastream/, you could > consider inlining their bodies. Done, I misremembered that I should out-of-line them but that's for virtual methods.
	18 };

	19

	20 } // namespace blink

	21

	22 #endif // MediaStreamTrack_h

OLD	NEW