Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: components/gcm_driver/gcm_driver_android.h

Issue 2578583002: Provide a mechanism for the GCM driver to send message receipts to GCM.
Patch Set: Added a callback entry point to GCMDriver, moved MessageReceiptCallback to gcm_message_status. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/gcm_driver/gcm_driver_android.h
diff --git a/components/gcm_driver/gcm_driver_android.h b/components/gcm_driver/gcm_driver_android.h
index ab5c9f3700aa1087c515270b70c4052e6c31856e..ba13f8435b69509f8cc4162abd1e3435a3b75b17 100644
--- a/components/gcm_driver/gcm_driver_android.h
+++ b/components/gcm_driver/gcm_driver_android.h
@@ -97,6 +97,10 @@ class GCMDriverAndroid : public GCMDriver,
override;
private:
+ void SendMessageReceipt(GCMMessageStatus status);
+ void DoSendMessageReceipt(const MessageReceiptCallback& callback,
+ GCMMessageSatus status);
Peter Beverloo 2017/02/08 17:09:09 nit: this won't compile (missing `override`). I ho
harkness 2017/02/09 16:27:30 Weird that this one isn't included in the componen
+
base::android::ScopedJavaGlobalRef<jobject> java_ref_;
// Callback for GetGCMStatistics.

Powered by Google App Engine
This is Rietveld 408576698