Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: components/gcm_driver/gcm_driver_android.cc

Issue 2578583002: Provide a mechanism for the GCM driver to send message receipts to GCM.
Patch Set: Added a callback entry point to GCMDriver, moved MessageReceiptCallback to gcm_message_status. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/gcm_driver/gcm_driver_android.cc
diff --git a/components/gcm_driver/gcm_driver_android.cc b/components/gcm_driver/gcm_driver_android.cc
index a512e8248d9a045c091c9c2440ec80577d1b26d8..c56ef8fe9c7cd644b86d6afd7fd5a9137b810fd5 100644
--- a/components/gcm_driver/gcm_driver_android.cc
+++ b/components/gcm_driver/gcm_driver_android.cc
@@ -109,7 +109,22 @@ void GCMDriverAndroid::OnMessageReceived(
recorder_.RecordDataMessageReceived(app_id, message.sender_id,
message_byte_size);
- DispatchMessage(app_id, message);
+ DispatchMessage(app_id, message,
+ base::Bind(&GCMDriverAndroid::SendMessageReceipt,
+ weak_ptr_factory_.GetWeakPtr()));
+}
+
+void GCMDriverAndroid::DoSendMessageReceipt(
+ const MessageReceiptCallback& callback,
+ GCMMessageStatus status) {
+ // All of the GCMDriverAndroid calls run on the UI thread, so just run the
+ // callback directly.
+ callback.Run(status);
+}
+
+void GCMDriverAndroid::SendMessageReceipt(GCMMessageStatus status) {
+ // TODO(harkness) Implement message receipts in android. crbug.com/674131.
+ NOTIMPLEMENTED();
Peter Beverloo 2017/02/08 17:09:09 nit: drop the NOTIMPLEMENTED() -- that'll just spa
harkness 2017/02/09 16:27:30 Done.
}
// static

Powered by Google App Engine
This is Rietveld 408576698