Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Side by Side Diff: components/gcm_driver/gcm_driver_android.h

Issue 2578583002: Provide a mechanism for the GCM driver to send message receipts to GCM.
Patch Set: Added a callback entry point to GCMDriver, moved MessageReceiptCallback to gcm_message_status. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_GCM_DRIVER_GCM_DRIVER_ANDROID_H 5 #ifndef COMPONENTS_GCM_DRIVER_GCM_DRIVER_ANDROID_H
6 #define COMPONENTS_GCM_DRIVER_GCM_DRIVER_ANDROID_H 6 #define COMPONENTS_GCM_DRIVER_GCM_DRIVER_ANDROID_H
7 7
8 #include <jni.h> 8 #include <jni.h>
9 9
10 #include "base/android/scoped_java_ref.h" 10 #include "base/android/scoped_java_ref.h"
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
90 void UnregisterWithSenderIdImpl(const std::string& app_id, 90 void UnregisterWithSenderIdImpl(const std::string& app_id,
91 const std::string& sender_id) override; 91 const std::string& sender_id) override;
92 void SendImpl(const std::string& app_id, 92 void SendImpl(const std::string& app_id,
93 const std::string& receiver_id, 93 const std::string& receiver_id,
94 const OutgoingMessage& message) override; 94 const OutgoingMessage& message) override;
95 void RecordDecryptionFailure(const std::string& app_id, 95 void RecordDecryptionFailure(const std::string& app_id,
96 GCMEncryptionProvider::DecryptionResult result) 96 GCMEncryptionProvider::DecryptionResult result)
97 override; 97 override;
98 98
99 private: 99 private:
100 void SendMessageReceipt(GCMMessageStatus status);
101 void DoSendMessageReceipt(const MessageReceiptCallback& callback,
102 GCMMessageSatus status);
Peter Beverloo 2017/02/08 17:09:09 nit: this won't compile (missing `override`). I ho
harkness 2017/02/09 16:27:30 Weird that this one isn't included in the componen
103
100 base::android::ScopedJavaGlobalRef<jobject> java_ref_; 104 base::android::ScopedJavaGlobalRef<jobject> java_ref_;
101 105
102 // Callback for GetGCMStatistics. 106 // Callback for GetGCMStatistics.
103 GetGCMStatisticsCallback get_gcm_statistics_callback_; 107 GetGCMStatisticsCallback get_gcm_statistics_callback_;
104 108
105 // Recorder that logs GCM activities. 109 // Recorder that logs GCM activities.
106 GCMStatsRecorderAndroid recorder_; 110 GCMStatsRecorderAndroid recorder_;
107 111
108 DISALLOW_COPY_AND_ASSIGN(GCMDriverAndroid); 112 DISALLOW_COPY_AND_ASSIGN(GCMDriverAndroid);
109 }; 113 };
110 114
111 } // namespace gcm 115 } // namespace gcm
112 116
113 #endif // COMPONENTS_GCM_DRIVER_GCM_DRIVER_ANDROID_H 117 #endif // COMPONENTS_GCM_DRIVER_GCM_DRIVER_ANDROID_H
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698