Provide a mechanism for the GCM driver to send message receipts to GCM.

components/gcm_driver/gcm_driver_android.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/gcm_driver/gcm_driver_android.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include "base/android/context_utils.h"
@@ skipping 91 matching lines @@
     std::vector<uint8_t> raw_data;
     JavaByteArrayToByteVector(env, j_raw_data, &raw_data);
     message.raw_data.assign(raw_data.begin(), raw_data.end());
 
     message_byte_size += message.raw_data.size();
   }
 
   recorder_.RecordDataMessageReceived(app_id, message.sender_id,
                                       message_byte_size);
 
-  DispatchMessage(app_id, message);
+  DispatchMessage(app_id, message,
+                  base::Bind(&GCMDriverAndroid::SendMessageReceipt,
+                             weak_ptr_factory_.GetWeakPtr()));
+}
+
+void GCMDriverAndroid::DoSendMessageReceipt(
+    const MessageReceiptCallback& callback,
+    GCMMessageStatus status) {
+  // All of the GCMDriverAndroid calls run on the UI thread, so just run the
+  // callback directly.
+  callback.Run(status);
+}
+
+void GCMDriverAndroid::SendMessageReceipt(GCMMessageStatus status) {
+  // TODO(harkness) Implement message receipts in android. crbug.com/674131.
+  NOTIMPLEMENTED();

[Peter Beverloo, 2017/02/08 17:09:09]

nit: drop the NOTIMPLEMENTED() -- that'll just spam the console

[harkness, 2017/02/09 16:27:30]

Done.

 }
 
 // static
 bool GCMDriverAndroid::RegisterJni(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 void GCMDriverAndroid::OnSignedIn() {
 }
 
@@ skipping 137 matching lines @@
   NOTIMPLEMENTED();
 }
 
 void GCMDriverAndroid::RecordDecryptionFailure(
     const std::string& app_id,
     GCMEncryptionProvider::DecryptionResult result) {
   recorder_.RecordDecryptionFailure(app_id, result);
 }
 
 }  // namespace gcm