Reland of Supervised Users: Create ResourceThrottle only if filtering is enabled

Reland of Supervised Users: Create ResourceThrottle only if filtering is enabled (patchset #1 id:1 of https://codereview.chromium.org/2568953002/ )

Reason for revert:
Going to address the problems in the reland CL.

Original issue's description:
> Revert of Supervised Users: Create ResourceThrottle only if filtering is enabled (patchset #3 id:40001 of https://codereview.chromium.org/2564043002/ )
> 
> Reason for revert:
> This is believed to have increased the rate of failure for SupervisedUserContentProviderTest#testWithSupervisedUser on linux_android_rel_ng.
> 
> See http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk%20%28with%20patch%29&builder=tryserver.chromium.android%3Alinux_android_rel_ng for dramatic increase in failure rate after this CL landed.
> 
> Example failure: https://chromium-swarm.appspot.com/task?id=330d0f66aec28810
> 
> Original issue's description:
> > Supervised Users: Create ResourceThrottle only if filtering is enabled
> >
> > Before this CL, we were creating a SupervisedUserResourceThrottle for
> > each top-level navigation. If the current user isn't supervised, this is
> > pointless. One side-effect was that we were recording
> > ManagerUsers.Filter* histograms for all navigations, including for
> > non-supervised users.
> >
> > This CL adds an "enabled" field on SupervisedUserURLFilter, which is set
> > to true iff the user is supervised. This allows us to not create the
> > resource throttle for regular users.
> >
> > BUG=671472
> >
> > Committed: https://crrev.com/54cf4ab900ab78c713bb4d53489f0571a433df24
> > Cr-Commit-Position: refs/heads/master@{#437868}
> 
> TBR=bauerb@chromium.org,treib@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=671472
> 
> Committed: https://crrev.com/ac24b64ae94c5950d4452c28ca834e156ed4275a
> Cr-Commit-Position: refs/heads/master@{#437910}

TBR=bauerb@chromium.org,bpastene@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=671472

[Marc Treib, 2016-12-14 13:27:28]

Created Reland of Supervised Users: Create ResourceThrottle only if filtering is
enabled

[Marc Treib, 2016-12-14 13:30:17]

On 2016/12/14 13:27:28, Marc Treib wrote:
> Created Reland of Supervised Users: Create ResourceThrottle only if filtering
is
> enabled

Sorry for the spam - nothing to see here yet; I'll ping once there is something
to review.

[Marc Treib, 2016-12-14 13:30:23]

Description was changed from

==========
Reland of Supervised Users: Create ResourceThrottle only if filtering is enabled
(patchset #1 id:1 of https://codereview.chromium.org/2568953002/ )

Reason for revert:
Going to address the problems in the reland CL.

Original issue's description:
> Revert of Supervised Users: Create ResourceThrottle only if filtering is
enabled (patchset #3 id:40001 of https://codereview.chromium.org/2564043002/ )
> 
> Reason for revert:
> This is believed to have increased the rate of failure for
SupervisedUserContentProviderTest#testWithSupervisedUser on
linux_android_rel_ng.
> 
> See
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=...
for dramatic increase in failure rate after this CL landed.
> 
> Example failure: https://chromium-swarm.appspot.com/task?id=330d0f66aec28810
> 
> Original issue's description:
> > Supervised Users: Create ResourceThrottle only if filtering is enabled
> >
> > Before this CL, we were creating a SupervisedUserResourceThrottle for
> > each top-level navigation. If the current user isn't supervised, this is
> > pointless. One side-effect was that we were recording
> > ManagerUsers.Filter* histograms for all navigations, including for
> > non-supervised users.
> >
> > This CL adds an "enabled" field on SupervisedUserURLFilter, which is set
> > to true iff the user is supervised. This allows us to not create the
> > resource throttle for regular users.
> >
> > BUG=671472
> >
> > Committed: https://crrev.com/54cf4ab900ab78c713bb4d53489f0571a433df24
> > Cr-Commit-Position: refs/heads/master@{#437868}
> 
> TBR=bauerb@chromium.org,treib@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=671472
> 
> Committed: https://crrev.com/ac24b64ae94c5950d4452c28ca834e156ed4275a
> Cr-Commit-Position: refs/heads/master@{#437910}

TBR=bauerb@chromium.org,bpastene@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=671472
==========

to

==========
Reland of Supervised Users: Create ResourceThrottle only if filtering is enabled
(patchset #1 id:1 of https://codereview.chromium.org/2568953002/ )

Reason for revert:
Going to address the problems in the reland CL.

Original issue's description:
> Revert of Supervised Users: Create ResourceThrottle only if filtering is
enabled (patchset #3 id:40001 of https://codereview.chromium.org/2564043002/ )
> 
> Reason for revert:
> This is believed to have increased the rate of failure for
SupervisedUserContentProviderTest#testWithSupervisedUser on
linux_android_rel_ng.
> 
> See
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=...
for dramatic increase in failure rate after this CL landed.
> 
> Example failure: https://chromium-swarm.appspot.com/task?id=330d0f66aec28810
> 
> Original issue's description:
> > Supervised Users: Create ResourceThrottle only if filtering is enabled
> >
> > Before this CL, we were creating a SupervisedUserResourceThrottle for
> > each top-level navigation. If the current user isn't supervised, this is
> > pointless. One side-effect was that we were recording
> > ManagerUsers.Filter* histograms for all navigations, including for
> > non-supervised users.
> >
> > This CL adds an "enabled" field on SupervisedUserURLFilter, which is set
> > to true iff the user is supervised. This allows us to not create the
> > resource throttle for regular users.
> >
> > BUG=671472
> >
> > Committed: https://crrev.com/54cf4ab900ab78c713bb4d53489f0571a433df24
> > Cr-Commit-Position: refs/heads/master@{#437868}
> 
> TBR=bauerb@chromium.org,treib@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=671472
> 
> Committed: https://crrev.com/ac24b64ae94c5950d4452c28ca834e156ed4275a
> Cr-Commit-Position: refs/heads/master@{#437910}

TBR=bauerb@chromium.org,bpastene@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=671472
==========

[Marc Treib, 2016-12-14 13:30:23]

treib@chromium.org changed reviewers:
- bpastene@chromium.org

[Marc Treib, 2017-04-04 09:39:59]

On 2016/12/14 13:30:17, Marc Treib wrote:
> On 2016/12/14 13:27:28, Marc Treib wrote:
> > Created Reland of Supervised Users: Create ResourceThrottle only if
filtering
> is
> > enabled
> 
> Sorry for the spam - nothing to see here yet; I'll ping once there is
something
> to review.

In the meantime, much has changed, so it doesn't make sense anymore to call this
a re-land. I'm closing this CL; it's being replaced by
https://codereview.chromium.org/2795993002.