Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2116)

Unified Diff: chrome/browser/supervised_user/supervised_user_url_filter_unittest.cc

Issue 2578533002: Reland of Supervised Users: Create ResourceThrottle only if filtering is enabled (Closed)
Patch Set: rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/supervised_user/supervised_user_url_filter.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/supervised_user/supervised_user_url_filter_unittest.cc
diff --git a/chrome/browser/supervised_user/supervised_user_url_filter_unittest.cc b/chrome/browser/supervised_user/supervised_user_url_filter_unittest.cc
index e306abc52c359525643446f13cf1fc76136b6356..bbac7baea694c3a203e4e027ead990f5a0b1f5a0 100644
--- a/chrome/browser/supervised_user/supervised_user_url_filter_unittest.cc
+++ b/chrome/browser/supervised_user/supervised_user_url_filter_unittest.cc
@@ -22,6 +22,7 @@ class SupervisedUserURLFilterTest : public ::testing::Test,
public:
SupervisedUserURLFilterTest() : filter_(new SupervisedUserURLFilter) {
filter_->SetDefaultFilteringBehavior(SupervisedUserURLFilter::BLOCK);
+ filter_->SetEnabled(true);
filter_->AddObserver(this);
}
@@ -68,6 +69,11 @@ TEST_F(SupervisedUserURLFilterTest, Basic) {
EXPECT_TRUE(IsURLWhitelisted("chrome://extensions/"));
EXPECT_TRUE(IsURLWhitelisted("chrome-extension://foo/main.html"));
EXPECT_TRUE(IsURLWhitelisted("file:///home/chronos/user/Downloads/img.jpg"));
+
+ // If the filter is disabled, everything should be allowed.
+ filter_->SetEnabled(false);
+ EXPECT_TRUE(IsURLWhitelisted("http://google.com"));
+ EXPECT_TRUE(IsURLWhitelisted("http://notgoogle.com/"));
}
TEST_F(SupervisedUserURLFilterTest, EffectiveURL) {
« no previous file with comments | « chrome/browser/supervised_user/supervised_user_url_filter.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698