Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Unified Diff: chrome/browser/supervised_user/supervised_user_resource_throttle_browsertest.cc

Issue 2578533002: Reland of Supervised Users: Create ResourceThrottle only if filtering is enabled (Closed)
Patch Set: rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/supervised_user/supervised_user_resource_throttle_browsertest.cc
diff --git a/chrome/browser/supervised_user/supervised_user_resource_throttle_browsertest.cc b/chrome/browser/supervised_user/supervised_user_resource_throttle_browsertest.cc
index 2daabe017651f8d28c426ee0155827f44edb8aa8..78102b4c58c8803e4c9778388561357dc823920c 100644
--- a/chrome/browser/supervised_user/supervised_user_resource_throttle_browsertest.cc
+++ b/chrome/browser/supervised_user/supervised_user_resource_throttle_browsertest.cc
@@ -137,3 +137,28 @@ IN_PROC_BROWSER_TEST_F(SupervisedUserResourceThrottleTest, DontBlockSubFrame) {
ASSERT_TRUE(content::ExecuteScriptAndExtractBool(tab, "loaded2()", &loaded2));
EXPECT_TRUE(loaded2);
}
+
+class SupervisedUserResourceThrottleNotSupervisedTest
+ : public SupervisedUserResourceThrottleTest {
+ protected:
+ SupervisedUserResourceThrottleNotSupervisedTest() {}
+ ~SupervisedUserResourceThrottleNotSupervisedTest() override {}
+
+ private:
+ // Overridden to do nothing, so that the supervised user ID will be empty.
+ void SetUpCommandLine(base::CommandLine* command_line) override {}
+};
+
+IN_PROC_BROWSER_TEST_F(SupervisedUserResourceThrottleNotSupervisedTest,
+ DontBlock) {
+ BlockHost(kExampleHost);
+
+ WebContents* tab = browser()->tab_strip_model()->GetActiveWebContents();
+
+ GURL blocked_url = embedded_test_server()->GetURL(
+ kExampleHost, "/supervised_user/simple.html");
+ ui_test_utils::NavigateToURL(browser(), blocked_url);
+ // Even though the URL is marked as blocked, the load should go through, since
+ // the user isn't supervised.
+ EXPECT_FALSE(tab->ShowingInterstitialPage());
+}

Powered by Google App Engine
This is Rietveld 408576698