Changed EVerticalAlign to an enum class and renamed its members

Changed EVerticalAlign to an enum class and renamed its members

Changed EVerticalAlign to an enum class and gave it an unsigned
underlying type.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to move EVerticalAlign to be generated in
ComputedStyleBase.

BUG=628043
Committed: https://crrev.com/2f0c2019085dfcf95005bb54b9eb483893e8cb1d
Cr-Commit-Position: refs/heads/master@{#440009}

[sashab, 2016-12-16 03:41:09]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[sashab, 2016-12-16 03:41:22]

sashab@chromium.org changed reviewers:
+ napper@chromium.org

[sashab, 2016-12-16 03:41:22]

One last patch ;)

[commit-bot: I haz the power, 2016-12-16 03:41:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 04:43:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 04:43:58]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sashab, 2016-12-20 22:59:13]

sashab@chromium.org changed reviewers:
+ meade@chromium.org

[sashab, 2016-12-20 22:59:14]

Oops, napper has gone on holiday lol. Eddy ptal, mainly a rename patch :)

[meade_UTC10, 2016-12-21 00:35:53]

lgtm

[sashab, 2016-12-21 00:36:36]

The CQ bit was checked by sashab@chromium.org

[commit-bot: I haz the power, 2016-12-21 00:37:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 04:12:19]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482280596761460, "parent_rev":
"8a2ecb91464e7434b19b404a35a340547f4a6fc0", "commit_rev":
"28af83bd4660450da3b72b9e69dbf1aec5979043"}

[commit-bot: I haz the power, 2016-12-21 04:13:28]

Description was changed from

==========
Changed EVerticalAlign to an enum class and renamed its members

Changed EVerticalAlign to an enum class and gave it an unsigned
underlying type.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to move EVerticalAlign to be generated in
ComputedStyleBase.

BUG=628043
==========

to

==========
Changed EVerticalAlign to an enum class and renamed its members

Changed EVerticalAlign to an enum class and gave it an unsigned
underlying type.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to move EVerticalAlign to be generated in
ComputedStyleBase.

BUG=628043

Review-Url: https://codereview.chromium.org/2578403002
==========

[commit-bot: I haz the power, 2016-12-21 04:13:29]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-21 04:15:23]

Description was changed from

==========
Changed EVerticalAlign to an enum class and renamed its members

Changed EVerticalAlign to an enum class and gave it an unsigned
underlying type.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to move EVerticalAlign to be generated in
ComputedStyleBase.

BUG=628043

Review-Url: https://codereview.chromium.org/2578403002
==========

to

==========
Changed EVerticalAlign to an enum class and renamed its members

Changed EVerticalAlign to an enum class and gave it an unsigned
underlying type.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to move EVerticalAlign to be generated in
ComputedStyleBase.

BUG=628043

Committed: https://crrev.com/2f0c2019085dfcf95005bb54b9eb483893e8cb1d
Cr-Commit-Position: refs/heads/master@{#440009}
==========

[commit-bot: I haz the power, 2016-12-21 04:15:24]

Patchset 1 (id:??) landed as
https://crrev.com/2f0c2019085dfcf95005bb54b9eb483893e8cb1d
Cr-Commit-Position: refs/heads/master@{#440009}