third_party/WebKit/Source/core/css/CSSPropertyEquality.cpp - Issue 2578403002: Changed EVerticalAlign to an enum class and renamed its members

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSPropertyEquality.cpp

Issue 2578403002: Changed EVerticalAlign to an enum class and renamed its members (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/CSSPropertyEquality.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSPropertyEquality.cpp b/third_party/WebKit/Source/core/css/CSSPropertyEquality.cpp

index 63d0f7e3846f59ac6270d2b4db6b9200744d45ef..e4efe3d62e6c09d78b1376ffb00ae31cd44c8892 100644

--- a/third_party/WebKit/Source/core/css/CSSPropertyEquality.cpp

+++ b/third_party/WebKit/Source/core/css/CSSPropertyEquality.cpp

@@ -268,7 +268,7 @@ bool CSSPropertyEquality::propertiesEqual(CSSPropertyID prop,

return a.top() == b.top();

case CSSPropertyVerticalAlign:

return a.verticalAlign() == b.verticalAlign() &&

- (a.verticalAlign() != VerticalAlignLength ||

+ (a.verticalAlign() != EVerticalAlign::Length ||

a.getVerticalAlignLength() == b.getVerticalAlignLength());

case CSSPropertyVisibility:

return a.visibility() == b.visibility();