Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 2578303002: Revert of [DevTools] Migrate target domain to new generator. (Closed)

Created:
4 years ago by dgozman
Modified:
4 years ago
Reviewers:
caseq
CC:
chromium-reviews, jam, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [DevTools] Migrate target domain to new generator. (patchset #2 id:20001 of https://codereview.chromium.org/2574843003/ ) Reason for revert: Speculative Original issue's description: > [DevTools] Migrate target domain to new generator. > > BUG=664683 > TBR=pfeldman > > Committed: https://crrev.com/a1a32123e28de766b5df3c82ec9ed9f8ddadd724 > Cr-Commit-Position: refs/heads/master@{#438733} TBR=caseq@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=664683 Committed: https://crrev.com/70847052d87dab3241593b925f87b2b96c031b7e Cr-Commit-Position: refs/heads/master@{#438940}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -93 lines) Patch
M content/browser/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/devtools/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/devtools/protocol/devtools_protocol_handler_generator.py View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/protocol/target_handler.h View 4 chunks +29 lines, -32 lines 0 comments Download
M content/browser/devtools/protocol/target_handler.cc View 15 chunks +48 lines, -38 lines 0 comments Download
M content/browser/devtools/protocol_config.json View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.h View 3 chunks +2 lines, -2 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.cc View 9 chunks +7 lines, -13 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
dgozman
Created Revert of [DevTools] Migrate target domain to new generator.
4 years ago (2016-12-15 22:31:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2578303002/1
4 years ago (2016-12-15 22:38:42 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 22:41:02 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/70847052d87dab3241593b925f87b2b96c031b7e Cr-Commit-Position: refs/heads/master@{#438940}
4 years ago (2016-12-15 22:43:19 UTC) #8
dgozman
4 years ago (2016-12-16 05:29:23 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2581103002/ by dgozman@chromium.org.

The reason for reverting is: Fixed crash reason in
https://codereview.chromium.org/2579923002/.

Powered by Google App Engine
This is Rietveld 408576698