Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2578253002: Prevent coordinate transformation when targeting the root RWHV (Closed)

Created:
4 years ago by kenrb
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Prevent coordinate transformation when targeting the root RWHV In some cases, an input event being targeted to the root RWHV was going through coordinate transformation, while in other cases it was not. This is normally fine because it is the identity transform anyway, but it can result in rounding error when there is a non-integer device scale factor. This was noted to cause a bug related to selections not being cleared because of coordinates from a transformed (rounded) event being compared against coordinates from a non-tranformed (unrounded) input event. This CL prevents transformation in all cases when the root is being targeted and the event is already in the coordinate space of the root. BUG=670253 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2567093003 Cr-Commit-Position: refs/heads/master@{#438012} (cherry picked from commit e3a974bb76247be74aaed25df318cdffce664ff5) Committed: https://chromium.googlesource.com/chromium/src/+/ab78460362a28fe9464d431214bf42b854488873

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -1 line) Patch
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 1 chunk +6 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/site_per_process_browsertest.cc View 2 chunks +75 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
kenrb
4 years ago (2016-12-15 20:55:46 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ab78460362a28fe9464d431214bf42b854488873.

Powered by Google App Engine
This is Rietveld 408576698