Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Side by Side Diff: content/browser/renderer_host/render_widget_host_view_aura.cc

Issue 2578253002: Prevent coordinate transformation when targeting the root RWHV (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/renderer_host/render_widget_host_view_aura.h" 5 #include "content/browser/renderer_host/render_widget_host_view_aura.h"
6 6
7 #include <set> 7 #include <set>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/auto_reset.h" 10 #include "base/auto_reset.h"
(...skipping 1638 matching lines...) Expand 10 before | Expand all | Expand 10 after
1649 return false; 1649 return false;
1650 *transformed_point = 1650 *transformed_point =
1651 gfx::ConvertPointToDIP(device_scale_factor_, *transformed_point); 1651 gfx::ConvertPointToDIP(device_scale_factor_, *transformed_point);
1652 return true; 1652 return true;
1653 } 1653 }
1654 1654
1655 bool RenderWidgetHostViewAura::TransformPointToCoordSpaceForView( 1655 bool RenderWidgetHostViewAura::TransformPointToCoordSpaceForView(
1656 const gfx::Point& point, 1656 const gfx::Point& point,
1657 RenderWidgetHostViewBase* target_view, 1657 RenderWidgetHostViewBase* target_view,
1658 gfx::Point* transformed_point) { 1658 gfx::Point* transformed_point) {
1659 if (target_view == this) {
1660 *transformed_point = point;
1661 return true;
1662 }
1663
1659 // In TransformPointToLocalCoordSpace() there is a Point-to-Pixel conversion, 1664 // In TransformPointToLocalCoordSpace() there is a Point-to-Pixel conversion,
1660 // but it is not necessary here because the final target view is responsible 1665 // but it is not necessary here because the final target view is responsible
1661 // for converting before computing the final transform. 1666 // for converting before computing the final transform.
1662 return delegated_frame_host_->TransformPointToCoordSpaceForView( 1667 return delegated_frame_host_->TransformPointToCoordSpaceForView(
1663 point, target_view, transformed_point); 1668 point, target_view, transformed_point);
1664 } 1669 }
1665 1670
1666 void RenderWidgetHostViewAura::FocusedNodeChanged( 1671 void RenderWidgetHostViewAura::FocusedNodeChanged(
1667 bool editable, 1672 bool editable,
1668 const gfx::Rect& node_bounds_in_screen) { 1673 const gfx::Rect& node_bounds_in_screen) {
(...skipping 718 matching lines...) Expand 10 before | Expand all | Expand 10 after
2387 2392
2388 void RenderWidgetHostViewAura::SetPopupChild( 2393 void RenderWidgetHostViewAura::SetPopupChild(
2389 RenderWidgetHostViewAura* popup_child_host_view) { 2394 RenderWidgetHostViewAura* popup_child_host_view) {
2390 popup_child_host_view_ = popup_child_host_view; 2395 popup_child_host_view_ = popup_child_host_view;
2391 event_handler_->SetPopupChild( 2396 event_handler_->SetPopupChild(
2392 popup_child_host_view, 2397 popup_child_host_view,
2393 popup_child_host_view ? popup_child_host_view->event_handler() : nullptr); 2398 popup_child_host_view ? popup_child_host_view->event_handler() : nullptr);
2394 } 2399 }
2395 2400
2396 } // namespace content 2401 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698