Prevent coordinate transformation when targeting the root RWHV

Prevent coordinate transformation when targeting the root RWHV

In some cases, an input event being targeted to the root RWHV was going
through coordinate transformation, while in other cases it was not.
This is normally fine because it is the identity transform anyway, but
it can result in rounding error when there is a non-integer device
scale factor. This was noted to cause a bug related to selections not
being cleared because of coordinates from a transformed (rounded)
event being compared against coordinates from a non-tranformed
(unrounded) input event.

This CL prevents transformation in all cases when the root is being
targeted and the event is already in the coordinate space of the root.

BUG=670253
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/e3a974bb76247be74aaed25df318cdffce664ff5
Cr-Commit-Position: refs/heads/master@{#438012}

[kenrb, 2016-12-12 22:23:00]

Description was changed from

==========
Prevent coordinate transformation when targeting the root RWHV

In some cases, an input event being targeted to the root RWHV was going
through coordinate transformation, while in other cases it was not.
This is normally fine because it is the identity transform anyway, but
it can result in rounding error when there is a non-integer device
scale factor. This was noted to cause a bug related to selections not
being cleared because of coordinates from a transformed (rounded)
event being compared against coordinates from a non-tranformed
(unrounded) input event.

This CL prevents transformation in all cases when the root is being
targeted and the event is already in the coordinate space of the root.

BUG=670253
==========

to

==========
Prevent coordinate transformation when targeting the root RWHV

In some cases, an input event being targeted to the root RWHV was going
through coordinate transformation, while in other cases it was not.
This is normally fine because it is the identity transform anyway, but
it can result in rounding error when there is a non-integer device
scale factor. This was noted to cause a bug related to selections not
being cleared because of coordinates from a transformed (rounded)
event being compared against coordinates from a non-tranformed
(unrounded) input event.

This CL prevents transformation in all cases when the root is being
targeted and the event is already in the coordinate space of the root.

BUG=670253
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[kenrb, 2016-12-12 22:23:07]

The CQ bit was checked by kenrb@chromium.org to run a CQ dry run

[kenrb, 2016-12-12 22:24:08]

kenrb@chromium.org changed reviewers:
+ creis@chromium.org

[kenrb, 2016-12-12 22:24:08]

creis: PTAL?

[commit-bot: I haz the power, 2016-12-12 22:24:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Reis, 2016-12-12 23:10:16]

LGTM.  Thanks for the test!

[Charlie Reis, 2016-12-12 23:12:58]

The CQ bit was unchecked by creis@chromium.org

[Charlie Reis, 2016-12-12 23:13:02]

The CQ bit was checked by creis@chromium.org

[commit-bot: I haz the power, 2016-12-12 23:13:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 00:28:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 00:28:36]

Try jobs failed on following builders:
  linux_site_isolation on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[Charlie Reis, 2016-12-13 00:38:13]

The CQ bit was checked by creis@chromium.org

[commit-bot: I haz the power, 2016-12-13 00:39:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 03:06:26]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481589493572320, "parent_rev":
"6a60deb4244bcc45c04552745bdaa91c16a825b3", "commit_rev":
"02f02d115c165eed0b9ab2e1114def642d41df26"}

[commit-bot: I haz the power, 2016-12-13 03:06:55]

Description was changed from

==========
Prevent coordinate transformation when targeting the root RWHV

In some cases, an input event being targeted to the root RWHV was going
through coordinate transformation, while in other cases it was not.
This is normally fine because it is the identity transform anyway, but
it can result in rounding error when there is a non-integer device
scale factor. This was noted to cause a bug related to selections not
being cleared because of coordinates from a transformed (rounded)
event being compared against coordinates from a non-tranformed
(unrounded) input event.

This CL prevents transformation in all cases when the root is being
targeted and the event is already in the coordinate space of the root.

BUG=670253
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Prevent coordinate transformation when targeting the root RWHV

In some cases, an input event being targeted to the root RWHV was going
through coordinate transformation, while in other cases it was not.
This is normally fine because it is the identity transform anyway, but
it can result in rounding error when there is a non-integer device
scale factor. This was noted to cause a bug related to selections not
being cleared because of coordinates from a transformed (rounded)
event being compared against coordinates from a non-tranformed
(unrounded) input event.

This CL prevents transformation in all cases when the root is being
targeted and the event is already in the coordinate space of the root.

BUG=670253
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2567093003
==========

[commit-bot: I haz the power, 2016-12-13 03:06:56]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-13 03:10:54]

Description was changed from

==========
Prevent coordinate transformation when targeting the root RWHV

In some cases, an input event being targeted to the root RWHV was going
through coordinate transformation, while in other cases it was not.
This is normally fine because it is the identity transform anyway, but
it can result in rounding error when there is a non-integer device
scale factor. This was noted to cause a bug related to selections not
being cleared because of coordinates from a transformed (rounded)
event being compared against coordinates from a non-tranformed
(unrounded) input event.

This CL prevents transformation in all cases when the root is being
targeted and the event is already in the coordinate space of the root.

BUG=670253
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2567093003
==========

to

==========
Prevent coordinate transformation when targeting the root RWHV

In some cases, an input event being targeted to the root RWHV was going
through coordinate transformation, while in other cases it was not.
This is normally fine because it is the identity transform anyway, but
it can result in rounding error when there is a non-integer device
scale factor. This was noted to cause a bug related to selections not
being cleared because of coordinates from a transformed (rounded)
event being compared against coordinates from a non-tranformed
(unrounded) input event.

This CL prevents transformation in all cases when the root is being
targeted and the event is already in the coordinate space of the root.

BUG=670253
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/e3a974bb76247be74aaed25df318cdffce664ff5
Cr-Commit-Position: refs/heads/master@{#438012}
==========

[commit-bot: I haz the power, 2016-12-13 03:10:55]

Patchset 1 (id:??) landed as
https://crrev.com/e3a974bb76247be74aaed25df318cdffce664ff5
Cr-Commit-Position: refs/heads/master@{#438012}