Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2578183003: Use .service.exe extension for service binaries on Windows (Closed)

Created:
4 years ago by Ken Rockot(use gerrit already)
Modified:
4 years ago
CC:
brucedawson, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use .service.exe extension for service binaries on Windows This is a simple solution to avoid conflicting ILK filenames generated by the linker, which apparently just strips the output file extension. BUG=673521 TBR=ben@chromium.org Committed: https://crrev.com/f5230da72019de8ae225833e75e94519cad77232 Cr-Commit-Position: refs/heads/master@{#438935}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -3 lines) Patch
M services/catalog/reader.cc View 2 chunks +8 lines, -1 line 0 comments Download
M services/service_manager/public/cpp/service.gni View 1 chunk +8 lines, -2 lines 0 comments Download
M services/service_manager/runner/host/child_process_host_unittest.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Ken Rockot(use gerrit already)
4 years ago (2016-12-15 20:44:15 UTC) #4
brucedawson
I also likes that this makes it clearer that the service binaries are executables. This ...
4 years ago (2016-12-15 20:48:36 UTC) #6
Ken Rockot(use gerrit already)
TBRing ben to land this
4 years ago (2016-12-15 20:50:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2578183003/1
4 years ago (2016-12-15 20:50:56 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 22:20:53 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-15 22:23:40 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f5230da72019de8ae225833e75e94519cad77232
Cr-Commit-Position: refs/heads/master@{#438935}

Powered by Google App Engine
This is Rietveld 408576698