Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: services/catalog/reader.cc

Issue 2578183003: Use .service.exe extension for service binaries on Windows (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | services/service_manager/public/cpp/service.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/catalog/reader.cc
diff --git a/services/catalog/reader.cc b/services/catalog/reader.cc
index 766aaf483dfcbb29388c1a44694d79c81164606e..67b15d37a6a935e245d2ff30b5a7540400685d6d 100644
--- a/services/catalog/reader.cc
+++ b/services/catalog/reader.cc
@@ -22,6 +22,12 @@
namespace catalog {
namespace {
+#if defined(OS_WIN)
+const char kServiceExecutableExtension[] = ".service.exe";
+#else
+const char kServiceExecutableExtension[] = ".service";
+#endif
+
base::FilePath GetManifestPath(const base::FilePath& package_dir,
const std::string& name,
const std::string& package_name_override) {
@@ -34,7 +40,8 @@ base::FilePath GetManifestPath(const base::FilePath& package_dir,
base::FilePath GetExecutablePath(const base::FilePath& package_dir,
const std::string& name) {
- return package_dir.AppendASCII(name + "/" + name + ".service");
+ return package_dir.AppendASCII(
+ name + "/" + name + kServiceExecutableExtension);
}
std::unique_ptr<Entry> ProcessManifest(
« no previous file with comments | « no previous file | services/service_manager/public/cpp/service.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698