components/ntp_snippets/remote/remote_suggestions_provider_unittest.cc - Issue 2578173002: NTP: Extract JSON requests from Fetcher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/remote/remote_suggestions_provider_unittest.cc

Issue 2578173002: NTP: Extract JSON requests from Fetcher. (Closed)

Patch Set: Use |GetVariationParamByFeatureAsBool|. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/ntp_snippets/remote/remote_suggestions_provider.cc ('k') | ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/remote/remote_suggestions_provider_unittest.cc

diff --git a/components/ntp_snippets/remote/remote_suggestions_provider_unittest.cc b/components/ntp_snippets/remote/remote_suggestions_provider_unittest.cc

index fd13c5d15b050af701c793b652e23993855cc8a0..9b290fd9e923904c9481f46623bce081e4d51e5f 100644

--- a/components/ntp_snippets/remote/remote_suggestions_provider_unittest.cc

+++ b/components/ntp_snippets/remote/remote_suggestions_provider_unittest.cc

@@ -305,10 +305,9 @@ gfx::Image FetchImage(RemoteSuggestionsProvider* service,

return result;

}

-void ParseJson(

- const std::string& json,

- const ntp_snippets::NTPSnippetsFetcher::SuccessCallback& success_callback,

- const ntp_snippets::NTPSnippetsFetcher::ErrorCallback& error_callback) {

+void ParseJson(const std::string& json,

+ const SuccessCallback& success_callback,

+ const ErrorCallback& error_callback) {

base::JSONReader json_reader;

std::unique_ptr<base::Value> value = json_reader.ReadToValue(json);

if (value) {