Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Unified Diff: components/ntp_snippets/remote/remote_suggestions_provider.cc

Issue 2578173002: NTP: Extract JSON requests from Fetcher. (Closed)
Patch Set: Use |GetVariationParamByFeatureAsBool|. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/remote/remote_suggestions_provider.cc
diff --git a/components/ntp_snippets/remote/remote_suggestions_provider.cc b/components/ntp_snippets/remote/remote_suggestions_provider.cc
index ea4551e9518b6f0b9ee066d93f785de4b2c3a5bd..103f6473b59f143fa5402fd7db3b015b3d9f9487 100644
--- a/components/ntp_snippets/remote/remote_suggestions_provider.cc
+++ b/components/ntp_snippets/remote/remote_suggestions_provider.cc
@@ -28,6 +28,7 @@
#include "components/ntp_snippets/category_rankers/category_ranker.h"
#include "components/ntp_snippets/features.h"
#include "components/ntp_snippets/pref_names.h"
+#include "components/ntp_snippets/remote/ntp_snippets_request_params.h"
#include "components/ntp_snippets/remote/remote_suggestions_database.h"
#include "components/ntp_snippets/switches.h"
#include "components/ntp_snippets/user_classifier.h"
@@ -416,7 +417,7 @@ void RemoteSuggestionsProvider::FetchSnippets(
MarkEmptyCategoriesAsLoading();
- NTPSnippetsFetcher::Params params = BuildFetchParams();
+ NTPSnippetsRequestParams params = BuildFetchParams();
params.interactive_request = interactive_request;
snippets_fetcher_->FetchSnippets(
params, base::BindOnce(&RemoteSuggestionsProvider::OnFetchFinished,
@@ -433,7 +434,7 @@ void RemoteSuggestionsProvider::Fetch(
"RemoteSuggestionsProvider is not ready!"));
return;
}
- NTPSnippetsFetcher::Params params = BuildFetchParams();
+ NTPSnippetsRequestParams params = BuildFetchParams();
params.excluded_ids.insert(known_suggestion_ids.begin(),
known_suggestion_ids.end());
params.interactive_request = true;
@@ -445,8 +446,8 @@ void RemoteSuggestionsProvider::Fetch(
}
// Builds default fetcher params.
-NTPSnippetsFetcher::Params RemoteSuggestionsProvider::BuildFetchParams() const {
- NTPSnippetsFetcher::Params result;
+NTPSnippetsRequestParams RemoteSuggestionsProvider::BuildFetchParams() const {
+ NTPSnippetsRequestParams result;
result.language_code = application_language_code_;
result.count_to_fetch = kMaxSnippetCount;
for (const auto& map_entry : category_contents_) {

Powered by Google App Engine
This is Rietveld 408576698