ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc - Issue 2578173002: NTP: Extract JSON requests from Fetcher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc

Issue 2578173002: NTP: Extract JSON requests from Fetcher. (Closed)

Patch Set: Use |GetVariationParamByFeatureAsBool|. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc

diff --git a/ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc b/ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc

index 0edacbf65a74656341541710b8d1e8ea3aac5c67..3dd4b40f985139e8236ef4c15d6981942bb75e27 100644

--- a/ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc

+++ b/ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc

@@ -59,8 +59,8 @@ using suggestions::ImageFetcherImpl;

namespace {

void ParseJson(const std::string& json,

- const NTPSnippetsFetcher::SuccessCallback& success_callback,

- const NTPSnippetsFetcher::ErrorCallback& error_callback) {

+ const ntp_snippets::SuccessCallback& success_callback,

+ const ntp_snippets::ErrorCallback& error_callback) {

base::JSONReader json_reader;

std::unique_ptr<base::Value> value = json_reader.ReadToValue(json);

if (value) {

« no previous file with comments | « components/ntp_snippets/remote/remote_suggestions_provider_unittest.cc ('k') | no next file » | no next file with comments »