Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 2578093003: ContentViewCore.showActionMode()'s allowFallback param always true (Closed)

Created:
4 years ago by amaralp
Modified:
4 years ago
CC:
agrieve+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ContentViewCore.showActionMode()'s allowFallback param always true Removed parameter that is always set to true. Committed: https://crrev.com/78cd92a8c2f401564f7a8669bfa18da4d3d5acb1 Cr-Commit-Position: refs/heads/master@{#438948}

Patch Set 1 #

Patch Set 2 : fixed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 2 chunks +3 lines, -3 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java View 1 4 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
amaralp
PTAL
4 years ago (2016-12-15 22:09:10 UTC) #4
aelias_OOO_until_Jul13
lgtm
4 years ago (2016-12-15 22:39:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2578093003/20001
4 years ago (2016-12-15 22:45:02 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-15 23:27:23 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-15 23:29:59 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/78cd92a8c2f401564f7a8669bfa18da4d3d5acb1
Cr-Commit-Position: refs/heads/master@{#438948}

Powered by Google App Engine
This is Rietveld 408576698