Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 2578093003: ContentViewCore.showActionMode()'s allowFallback param always true (Closed)
Patch Set: fixed comment Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
index 87d4533b103cdbda38129a887284a03a6e6259fe..3c7a276a233076b289e8ebd80e17f7e348ea7a24 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
@@ -1801,8 +1801,8 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Displa
return mSelectionPopupController;
}
- private void showSelectActionMode(boolean allowFallback) {
- if (!mSelectionPopupController.showActionMode(allowFallback)) clearSelection();
+ private void showSelectActionMode() {
+ if (!mSelectionPopupController.showActionMode()) clearSelection();
}
public void clearSelection() {
@@ -2727,7 +2727,7 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Displa
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M
&& mSelectionPopupController.isActionModeValid()) {
hidePopupsAndPreserveSelection();
- showSelectActionMode(true);
+ showSelectActionMode();
}
int rotationDegrees = 0;
« no previous file with comments | « no previous file | content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698