Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(933)

Issue 2578053002: Worker: Stop running worker tests with BlinkGC::MainThreadHeapMode (Closed)

Created:
4 years ago by nhiroki
Modified:
4 years ago
Reviewers:
keishi, haraken
CC:
chromium-reviews, kinuko+worker_chromium.org, jsbell+serviceworker_chromium.org, tyoshino+watch_chromium.org, tzik, shimazu+serviceworker_chromium.org, hongchan, serviceworker-reviews, shimazu+worker_chromium.org, loading-reviews_chromium.org, michaeln, kinuko+serviceworker, gavinp+loader_chromium.org, Raymond Toy, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, Nate Chapin, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Worker: Stop running worker tests with BlinkGC::MainThreadHeapMode Oilpan's per-thread heap mode is already shipped for workers and we no longer have to run the tests on both BlinkGC::MainThreadHeapMode and BlinkGC::PerThreadHeapMode. BUG=674400 Committed: https://crrev.com/d82e162920b55095efa40a8052e9539d2cf861bb Cr-Commit-Position: refs/heads/master@{#438790}

Patch Set 1 #

Messages

Total messages: 17 (8 generated)
nhiroki
PTAL, thanks.
4 years ago (2016-12-15 07:46:12 UTC) #4
haraken
keishi@: Are we ready to remove code for non-per-thread heaps?
4 years ago (2016-12-15 08:00:15 UTC) #5
keishi
On 2016/12/15 08:00:15, haraken wrote: > keishi@: Are we ready to remove code for non-per-thread ...
4 years ago (2016-12-15 08:49:09 UTC) #6
keishi
On 2016/12/15 08:49:09, keishi wrote: > On 2016/12/15 08:00:15, haraken wrote: > > keishi@: Are ...
4 years ago (2016-12-15 08:50:04 UTC) #7
haraken
LGTM
4 years ago (2016-12-15 08:50:23 UTC) #8
nhiroki
Thank you for reviewing :) On 2016/12/15 08:49:09, keishi wrote: > On 2016/12/15 08:00:15, haraken ...
4 years ago (2016-12-15 09:10:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2578053002/1
4 years ago (2016-12-15 09:10:44 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 09:14:55 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-15 09:19:34 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d82e162920b55095efa40a8052e9539d2cf861bb
Cr-Commit-Position: refs/heads/master@{#438790}

Powered by Google App Engine
This is Rietveld 408576698