Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Unified Diff: third_party/WebKit/Source/core/workers/WorkerBackingThread.h

Issue 2578053002: Worker: Stop running worker tests with BlinkGC::MainThreadHeapMode (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/workers/WorkerBackingThread.h
diff --git a/third_party/WebKit/Source/core/workers/WorkerBackingThread.h b/third_party/WebKit/Source/core/workers/WorkerBackingThread.h
index ee1d4795342052b60260902313046bbd625357e0..9ebbcc9df2cca08128a268fa7228ea508e93525c 100644
--- a/third_party/WebKit/Source/core/workers/WorkerBackingThread.h
+++ b/third_party/WebKit/Source/core/workers/WorkerBackingThread.h
@@ -28,11 +28,8 @@ class WebThreadSupportingGC;
// WorkerGlobalScopes) can share one WorkerBackingThread.
class CORE_EXPORT WorkerBackingThread final {
public:
- static std::unique_ptr<WorkerBackingThread> create(
- const char* name,
- BlinkGC::ThreadHeapMode threadHeapMode) {
- return WTF::wrapUnique(
- new WorkerBackingThread(name, false, threadHeapMode));
+ static std::unique_ptr<WorkerBackingThread> create(const char* name) {
+ return WTF::wrapUnique(new WorkerBackingThread(name, false));
}
static std::unique_ptr<WorkerBackingThread> create(WebThread* thread) {
return WTF::wrapUnique(new WorkerBackingThread(thread, false));
@@ -40,10 +37,8 @@ class CORE_EXPORT WorkerBackingThread final {
// These are needed to suppress leak reports. See
// https://crbug.com/590802 and https://crbug.com/v8/1428.
- static std::unique_ptr<WorkerBackingThread> createForTest(
- const char* name,
- BlinkGC::ThreadHeapMode threadHeapMode) {
- return WTF::wrapUnique(new WorkerBackingThread(name, true, threadHeapMode));
+ static std::unique_ptr<WorkerBackingThread> createForTest(const char* name) {
+ return WTF::wrapUnique(new WorkerBackingThread(name, true));
}
static std::unique_ptr<WorkerBackingThread> createForTest(WebThread* thread) {
return WTF::wrapUnique(new WorkerBackingThread(thread, true));
@@ -71,9 +66,7 @@ class CORE_EXPORT WorkerBackingThread final {
static void setRAILModeOnWorkerThreadIsolates(v8::RAILMode);
private:
- WorkerBackingThread(const char* name,
- bool shouldCallGCOnShutdown,
- BlinkGC::ThreadHeapMode);
+ WorkerBackingThread(const char* name, bool shouldCallGCOnShutdown);
WorkerBackingThread(WebThread*, bool shouldCallGCOnSHutdown);
std::unique_ptr<WebThreadSupportingGC> m_backingThread;

Powered by Google App Engine
This is Rietveld 408576698