Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2577973002: Moved text-align to be generated in ComputedStyleBase. (Closed)

Created:
4 years ago by napper
Modified:
4 years ago
Reviewers:
sashab
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moved text-align to be generated in ComputedStyleBase. Move the inherited property text-align and its enum, ETextAlign, to be generated in ComputedStyleBase. Also moved getter / setter / initial value methods to be generated in ComputedStyleBase. BUG=628043 Committed: https://crrev.com/8b4b629e3b72663debb34643c16f4b32787bbfdf Cr-Commit-Position: refs/heads/master@{#438781}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Removed unneeded comment about text-align keyword ordering. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -28 lines) Patch
M third_party/WebKit/Source/core/css/CSSProperties.in View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 4 chunks +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 22 (14 generated)
napper
4 years ago (2016-12-15 02:43:11 UTC) #7
sashab
https://codereview.chromium.org/2577973002/diff/1/third_party/WebKit/Source/core/css/CSSProperties.in File third_party/WebKit/Source/core/css/CSSProperties.in (right): https://codereview.chromium.org/2577973002/diff/1/third_party/WebKit/Source/core/css/CSSProperties.in#newcode361 third_party/WebKit/Source/core/css/CSSProperties.in:361: // CSSValueKeywords.in. To fix this, do a pre-patch like ...
4 years ago (2016-12-15 02:58:31 UTC) #8
napper
On 2016/12/15 at 02:58:31, sashab wrote: > https://codereview.chromium.org/2577973002/diff/1/third_party/WebKit/Source/core/css/CSSProperties.in > File third_party/WebKit/Source/core/css/CSSProperties.in (right): > > https://codereview.chromium.org/2577973002/diff/1/third_party/WebKit/Source/core/css/CSSProperties.in#newcode361 ...
4 years ago (2016-12-15 03:59:15 UTC) #11
napper
4 years ago (2016-12-15 03:59:25 UTC) #12
sashab
Oh yeah, that's right, I did that already in here: https://codereview.chromium.org/2519813002 Cool lol. LGTM
4 years ago (2016-12-15 06:19:01 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2577973002/20001
4 years ago (2016-12-15 08:05:47 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-15 08:10:40 UTC) #20
commit-bot: I haz the power
4 years ago (2016-12-15 08:13:19 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8b4b629e3b72663debb34643c16f4b32787bbfdf
Cr-Commit-Position: refs/heads/master@{#438781}

Powered by Google App Engine
This is Rietveld 408576698