Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2519813002: Removed ordering dependencies for ETextAlign (Closed)

Created:
4 years, 1 month ago by sashab
Modified:
4 years, 1 month ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed ordering dependencies for ETextAlign Removed ordering dependencies for ETextAlign from CSSValueKeywords.h. Randomly re-ordered the keywords before running tests to ensure no ordering dependencies still exist, then reverted to original order for committing. BUG=665272 Committed: https://crrev.com/6d786157c078b244a5f6c3cfe5dffe986c2d5b83 Cr-Commit-Position: refs/heads/master@{#433490}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 1 chunk +15 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSValueKeywords.in View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
sashab
Sorry if I'm sending you too many reviews Alan! :)
4 years, 1 month ago (2016-11-21 04:37:18 UTC) #4
alancutter (OOO until 2018)
These hardly count as reviews they're so easy. (: lgtm.
4 years, 1 month ago (2016-11-21 05:13:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2519813002/1
4 years, 1 month ago (2016-11-21 05:14:21 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 07:07:51 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 07:10:25 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6d786157c078b244a5f6c3cfe5dffe986c2d5b83
Cr-Commit-Position: refs/heads/master@{#433490}

Powered by Google App Engine
This is Rietveld 408576698