Correctly hash the input of MatchModuleWhitelistString() in pver4.

Correctly hash the input of MatchModuleWhitelistString() in pver4.

Also add a test.

BUG=673827
Committed: https://crrev.com/b17e691af473e62bd8aa4c61b96b361234171feb
Cr-Commit-Position: refs/heads/master@{#438951}

[Nathan Parker, 2016-12-15 18:47:48]

The CQ bit was checked by nparker@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 18:48:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nathan Parker, 2016-12-15 18:51:07]

Description was changed from

==========
Correctly has the input of MatchModuleWhitelistString() in pver4.

Also add a test.

BUG=673827
==========

to

==========
Correctly hash the input of MatchModuleWhitelistString() in pver4.

Also add a test.

BUG=673827
==========

[Nathan Parker, 2016-12-15 18:51:26]

nparker@chromium.org changed reviewers:
+ shess@chromium.org

[Nathan Parker, 2016-12-15 18:51:27]

We can further tidy up the args in http://crbug.com/674636. I'm keeping this
small so it can be merged.

[Nathan Parker, 2016-12-15 18:52:35]

The CQ bit was checked by nparker@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 18:52:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Scott Hess - ex-Googler, 2016-12-15 19:15:03]

LGTM.

On 2016/12/15 18:51:27, Nathan Parker wrote:
> We can further tidy up the args in http://crbug.com/674636. I'm keeping this
> small so it can be merged.

Honestly, if you're holding off on renaming the function for merge-driven
reasons, then I'd also hold off on renaming the parameter, too.  Previously, the
reader didn't know what either "String" or "str" meant, so they'd have to go
look it up.  Changing the parameter name means they don't know whether "String"
or "module_filename" is the right interpretation, so they'll still have to look
it up.

Well, that and for merges smaller is better.

https://codereview.chromium.org/2577963004/diff/1/components/safe_browsing_db...
File components/safe_browsing_db/v4_local_database_manager_unittest.cc (right):

https://codereview.chromium.org/2577963004/diff/1/components/safe_browsing_db...
components/safe_browsing_db/v4_local_database_manager_unittest.cc:417:
WaitForTasksOnTaskRunner();
This stanza is getting noisy in this file!  I want to post a reference to a
recent article about consolidating test boilerplate in a way which doesn't
require the reader to comprehend it, but ... it was on Google+, so I'll never be
able to find that.

[commit-bot: I haz the power, 2016-12-15 21:05:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 21:05:35]

Dry run: This issue passed the CQ dry run.

[Nathan Parker, 2016-12-15 21:55:50]

Thanks.  I've removed the parameter name change

[Scott Hess - ex-Googler, 2016-12-15 21:56:33]

Still LGTM

[Nathan Parker, 2016-12-15 21:57:03]

The CQ bit was checked by nparker@chromium.org

[Nathan Parker, 2016-12-15 21:57:03]

The patchset sent to the CQ was uploaded after l-g-t-m from shess@chromium.org
Link to the patchset: https://codereview.chromium.org/2577963004/#ps40001
(title: "nit")

[commit-bot: I haz the power, 2016-12-15 21:57:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 23:31:10]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481839023133040,
"parent_rev": "01ebc9754a83f9563deb527346138c22b9ec80f0", "commit_rev":
"772290b243c45ea11feba51105ab6b1bbff14460"}

[commit-bot: I haz the power, 2016-12-15 23:31:41]

Description was changed from

==========
Correctly hash the input of MatchModuleWhitelistString() in pver4.

Also add a test.

BUG=673827
==========

to

==========
Correctly hash the input of MatchModuleWhitelistString() in pver4.

Also add a test.

BUG=673827

Review-Url: https://codereview.chromium.org/2577963004
==========

[commit-bot: I haz the power, 2016-12-15 23:31:42]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-15 23:36:32]

Description was changed from

==========
Correctly hash the input of MatchModuleWhitelistString() in pver4.

Also add a test.

BUG=673827

Review-Url: https://codereview.chromium.org/2577963004
==========

to

==========
Correctly hash the input of MatchModuleWhitelistString() in pver4.

Also add a test.

BUG=673827

Committed: https://crrev.com/b17e691af473e62bd8aa4c61b96b361234171feb
Cr-Commit-Position: refs/heads/master@{#438951}
==========

[commit-bot: I haz the power, 2016-12-15 23:36:33]

Patchset 3 (id:??) landed as
https://crrev.com/b17e691af473e62bd8aa4c61b96b361234171feb
Cr-Commit-Position: refs/heads/master@{#438951}