Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Unified Diff: components/safe_browsing_db/v4_local_database_manager_unittest.cc

Issue 2577963004: Correctly hash the input of MatchModuleWhitelistString() in pver4. (Closed)
Patch Set: nit Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/safe_browsing_db/v4_local_database_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/safe_browsing_db/v4_local_database_manager_unittest.cc
diff --git a/components/safe_browsing_db/v4_local_database_manager_unittest.cc b/components/safe_browsing_db/v4_local_database_manager_unittest.cc
index 7e8c4d6d134e07301ffd183a4c376d6d626c5889..e809b2c76bfdc2e39aeff65e2f7d219782f0a88e 100644
--- a/components/safe_browsing_db/v4_local_database_manager_unittest.cc
+++ b/components/safe_browsing_db/v4_local_database_manager_unittest.cc
@@ -11,6 +11,7 @@
#include "components/safe_browsing_db/v4_local_database_manager.h"
#include "components/safe_browsing_db/v4_test_util.h"
#include "content/public/test/test_browser_thread_bundle.h"
+#include "crypto/sha2.h"
#include "net/url_request/test_url_fetcher_factory.h"
#include "testing/platform_test.h"
@@ -407,4 +408,27 @@ TEST_F(V4LocalDatabaseManagerTest, TestMatchMalwareIP) {
v4_local_database_manager_));
}
+TEST_F(V4LocalDatabaseManagerTest, TestMatchModuleWhitelist) {
+ StopLocalDatabaseManager();
+ v4_local_database_manager_ =
+ make_scoped_refptr(new FakeV4LocalDatabaseManager(base_dir_.GetPath()));
+ SetTaskRunnerForTest();
+ StartLocalDatabaseManager();
+ WaitForTasksOnTaskRunner();
+
+ StoreAndHashPrefixes store_and_hash_prefixes;
+ store_and_hash_prefixes.emplace_back(GetChromeFilenameClientIncidentId(),
+ crypto::SHA256HashString("chrome.dll"));
+
+ ReplaceV4Database(store_and_hash_prefixes);
+
+ // No match -- i.e. not whitelisted
+ EXPECT_FALSE(
+ v4_local_database_manager_->MatchModuleWhitelistString("badstuff.dll"));
+
+ // Whitelisted.
+ EXPECT_TRUE(
+ v4_local_database_manager_->MatchModuleWhitelistString("chrome.dll"));
+}
+
} // namespace safe_browsing
« no previous file with comments | « components/safe_browsing_db/v4_local_database_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698