cros: Fix inconsistent SessionController state for tests

cros: Fix inconsistent SessionController state for tests

- Do not set ACTIVE state in StartRestoreAfterCrashSession and
  StartStubLoginSession. SessionStarted() call will do that. Setting
  it explicitly breaks tests such as AccessibilityManagerTest that
  has "--login-manager" but goes through StartRestoreAfterCrashSession
  code to initialize;
- CrashRestoreComplexTest should use GetLRULoggedInUsers instead
  of GetLoggedInUsers since it tests the user session order;
- Fix UserManagerBase to cover tests that add a non-existent user;
  - Make sure |logged_in_user_| preserves the order since its index is
    used as fake session id ATM;
  - Fire UserAddedToSession for such users;

BUG=648964
TEST=Existing tests.

Committed: https://crrev.com/8cb43c2a16b3341a3940b7919a8b61a4b93f2998
Cr-Commit-Position: refs/heads/master@{#438944}

[xiyuan, 2016-12-14 23:39:43]

xiyuan@chromium.org changed reviewers:
+ alemate@chromium.org

[xiyuan, 2016-12-14 23:39:44]

alemate, please review the change.

This is needed for James' https://codereview.chromium.org/2573703003/.

Thanks.

[xiyuan, 2016-12-14 23:39:51]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 23:40:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 00:22:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 00:22:34]

Dry run: This issue passed the CQ dry run.

[Alexander Alekseev, 2016-12-15 22:43:33]

lgtm

[xiyuan, 2016-12-15 22:45:17]

The CQ bit was checked by xiyuan@chromium.org

[commit-bot: I haz the power, 2016-12-15 22:46:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 22:59:23]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481841917080140, "parent_rev":
"4e504dea5fb9861a45d0f0d8bdb3048171b50290", "commit_rev":
"a40638940b8d009ded8ec901dbc2ba311055bf26"}

[commit-bot: I haz the power, 2016-12-15 22:59:58]

Description was changed from

==========
cros: Fix inconsistent SessionController state for tests

- Do not set ACTIVE state in StartRestoreAfterCrashSession and
  StartStubLoginSession. SessionStarted() call will do that. Setting
  it explicitly breaks tests such as AccessibilityManagerTest that
  has "--login-manager" but goes through StartRestoreAfterCrashSession
  code to initialize;
- CrashRestoreComplexTest should use GetLRULoggedInUsers instead
  of GetLoggedInUsers since it tests the user session order;
- Fix UserManagerBase to cover tests that add a non-existent user;
  - Make sure |logged_in_user_| preserves the order since its index is
    used as fake session id ATM;
  - Fire UserAddedToSession for such users;

BUG=648964
TEST=Existing tests.
==========

to

==========
cros: Fix inconsistent SessionController state for tests

- Do not set ACTIVE state in StartRestoreAfterCrashSession and
  StartStubLoginSession. SessionStarted() call will do that. Setting
  it explicitly breaks tests such as AccessibilityManagerTest that
  has "--login-manager" but goes through StartRestoreAfterCrashSession
  code to initialize;
- CrashRestoreComplexTest should use GetLRULoggedInUsers instead
  of GetLoggedInUsers since it tests the user session order;
- Fix UserManagerBase to cover tests that add a non-existent user;
  - Make sure |logged_in_user_| preserves the order since its index is
    used as fake session id ATM;
  - Fire UserAddedToSession for such users;

BUG=648964
TEST=Existing tests.

Review-Url: https://codereview.chromium.org/2577903002
==========

[commit-bot: I haz the power, 2016-12-15 22:59:59]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-15 23:03:20]

Description was changed from

==========
cros: Fix inconsistent SessionController state for tests

- Do not set ACTIVE state in StartRestoreAfterCrashSession and
  StartStubLoginSession. SessionStarted() call will do that. Setting
  it explicitly breaks tests such as AccessibilityManagerTest that
  has "--login-manager" but goes through StartRestoreAfterCrashSession
  code to initialize;
- CrashRestoreComplexTest should use GetLRULoggedInUsers instead
  of GetLoggedInUsers since it tests the user session order;
- Fix UserManagerBase to cover tests that add a non-existent user;
  - Make sure |logged_in_user_| preserves the order since its index is
    used as fake session id ATM;
  - Fire UserAddedToSession for such users;

BUG=648964
TEST=Existing tests.

Review-Url: https://codereview.chromium.org/2577903002
==========

to

==========
cros: Fix inconsistent SessionController state for tests

- Do not set ACTIVE state in StartRestoreAfterCrashSession and
  StartStubLoginSession. SessionStarted() call will do that. Setting
  it explicitly breaks tests such as AccessibilityManagerTest that
  has "--login-manager" but goes through StartRestoreAfterCrashSession
  code to initialize;
- CrashRestoreComplexTest should use GetLRULoggedInUsers instead
  of GetLoggedInUsers since it tests the user session order;
- Fix UserManagerBase to cover tests that add a non-existent user;
  - Make sure |logged_in_user_| preserves the order since its index is
    used as fake session id ATM;
  - Fire UserAddedToSession for such users;

BUG=648964
TEST=Existing tests.

Committed: https://crrev.com/8cb43c2a16b3341a3940b7919a8b61a4b93f2998
Cr-Commit-Position: refs/heads/master@{#438944}
==========

[commit-bot: I haz the power, 2016-12-15 23:03:21]

Patchset 1 (id:??) landed as
https://crrev.com/8cb43c2a16b3341a3940b7919a8b61a4b93f2998
Cr-Commit-Position: refs/heads/master@{#438944}