Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2046)

Unified Diff: chrome/browser/chromeos/login/session/chrome_session_manager.cc

Issue 2577903002: cros: Fix inconsistent SessionController state for tests (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/session/chrome_session_manager.cc
diff --git a/chrome/browser/chromeos/login/session/chrome_session_manager.cc b/chrome/browser/chromeos/login/session/chrome_session_manager.cc
index 194efe6379c98e87ab6343df008c229fc507cdcb..7a0cce367b8058d15a38ff1ee7ed1554391e2403 100644
--- a/chrome/browser/chromeos/login/session/chrome_session_manager.cc
+++ b/chrome/browser/chromeos/login/session/chrome_session_manager.cc
@@ -85,9 +85,6 @@ void StartRestoreAfterCrashSession(Profile* user_profile,
const std::string& login_user_id) {
base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
- session_manager::SessionManager::Get()->SetSessionState(
- session_manager::SessionState::ACTIVE);
-
// TODO(xiyuan): Identify tests that do not set this kLoginUser flag but
// still rely on "stub user" session. Keeping existing behavior to avoid
// breaking tests.
@@ -147,9 +144,6 @@ void StartRestoreAfterCrashSession(Profile* user_profile,
// Starts a user session with stub user.
void StartStubLoginSession(Profile* user_profile,
const std::string& login_user_id) {
- session_manager::SessionManager::Get()->SetSessionState(
- session_manager::SessionState::ACTIVE);
-
// For dev machines and stub user emulate as if sync has been initialized.
SigninManagerFactory::GetForProfile(user_profile)
->SetAuthenticatedAccountInfo(login_user_id, login_user_id);
« no previous file with comments | « chrome/browser/chromeos/login/crash_restore_browsertest.cc ('k') | components/user_manager/user_manager_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698