[chromecast] Deletes libcast_media_1.0_default_core.

chromecast/media/cma/backend/BUILD.gn

Index: chromecast/media/cma/backend/BUILD.gn
diff --git a/chromecast/media/cma/backend/BUILD.gn b/chromecast/media/cma/backend/BUILD.gn
index 359e67b8cafaacb2cd8bd75776be493b3a647a83..f970b2e824255b2e6c155575c2be46364ad3b266 100644
--- a/chromecast/media/cma/backend/BUILD.gn
+++ b/chromecast/media/cma/backend/BUILD.gn
@@ -2,20 +2,16 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+import("//build/config/chromecast_build.gni")
+
 source_set("backend") {
   sources = [
-    "audio_decoder_default.cc",
-    "audio_decoder_default.h",
     "audio_decoder_wrapper.cc",
     "audio_decoder_wrapper.h",
-    "media_pipeline_backend_default.cc",
-    "media_pipeline_backend_default.h",
     "media_pipeline_backend_manager.cc",
     "media_pipeline_backend_manager.h",
     "media_pipeline_backend_wrapper.cc",
     "media_pipeline_backend_wrapper.h",
-    "video_decoder_default.cc",
-    "video_decoder_default.h",
   ]
 
   public_deps = [
@@ -27,4 +23,53 @@ source_set("backend") {
     "//base",
     "//chromecast:chromecast_features",
   ]
+
+  if (is_android) {
+    sources += [ "cast_media_android.cc" ]

[byungchul, 2016/12/16 18:26:29]

why doesn't android link libcast_media? In general, I prefer one shlib for atv
cast receiver (libcast_receiver.so), but libcast_media was already split for
atv.

[alokp, 2016/12/16 18:29:37]

slan@ asked me to do this

[slan, 2016/12/16 23:04:14]

This was split only recently (https://codereview.chromium.org/2508803012), and I
don't think that it was the right change. Why deviate from our pattern, and add
a shlib if not necessary?

[byungchul, 2016/12/16 23:53:00]

I am also fine with this as long as Luke is fine.

+  } else {
+    deps += [ ":libcast_media_1.0" ]
+  }
+}
+
+# Target for OEM partners to override media shared library, i.e.
+# libcast_media_1.0.so. This target is only used to build executables
+# with correct linkage information.
+shared_library("libcast_media_1.0") {

[byungchul, 2016/12/16 18:26:29]

@Stepghen,

Doesn't it need a version script to expose only media shlib interface?

[alokp, 2016/12/16 18:29:37]

We have scrapped the version script idea for now AFAIK

[slan, 2016/12/16 23:04:14]

Byungchul: This is OK, because we are only linking in the extra symbols on the
cast_desktop build, where we will never swap out the library at runtime. So it
doesn't matter where the symbols come from. 

Non-desktop builds require us to swap the lib out at runtime. Therefore we can't
link anything except cast_media_dummy.

[byungchul, 2016/12/16 23:53:00]

Okay, then production build still links libcast_media_dummy?

+  deps = [
+    "//chromecast/public",
+    "//chromecast/public/media",
+  ]
+
+  if (is_cast_desktop_build) {
+    sources = [
+      "cast_media_default.cc",
+    ]
+    deps += [
+      ":default",
+      "//base",
+      "//chromecast/base",
+    ]
+  } else {
+    sources = [
+      "cast_media_dummy.cc",
+    ]
+  }
+}
+
+# Default implementation of media backend used on desktop.
+source_set("default") {
+  sources = [
+    "audio_decoder_default.cc",
+    "audio_decoder_default.h",
+    "media_pipeline_backend_default.cc",
+    "media_pipeline_backend_default.h",
+    "video_decoder_default.cc",
+    "video_decoder_default.h",
+  ]
+
+  deps = [
+    "//base",
+    "//chromecast/base",
+    "//chromecast/public/media",
+  ]
 }