Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Unified Diff: chromecast/media/BUILD.gn

Issue 2577743002: [chromecast] Deletes libcast_media_1.0_default_core. (Closed)
Patch Set: moves backend files to cma/backend Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/media/BUILD.gn
diff --git a/chromecast/media/BUILD.gn b/chromecast/media/BUILD.gn
index 5c90a22f45046b5412515414385964a93deff5ec..25162a80279f21a6622a3a183bac4536ed0572f6 100644
--- a/chromecast/media/BUILD.gn
+++ b/chromecast/media/BUILD.gn
@@ -58,39 +58,16 @@ test("cast_media_unittests") {
"//testing/gtest",
"//ui/display",
"//ui/gfx/geometry",
- ]
-
- if (chromecast_branding == "public") {
- # Link default libcast_media_1.0 statically not to link dummy one
- # dynamically for public unittests.
- deps += [ "//chromecast/media/base:libcast_media_1.0_default_core" ]
- }
-}
-
-test("cast_multizone_backend_unittests") {
- sources = [
- "cma/backend/multizone_backend_unittest.cc",
- "cma/test/run_all_unittests.cc",
- ]
- deps = [
- "//base",
- "//base/test:test_support",
- "//chromecast/base",
- "//chromecast/base/metrics:test_support",
- "//chromecast/media/base:libcast_media_1.0",
- "//chromecast/media/cma/backend",
- "//chromecast/media/cma/base",
- "//chromecast/public",
- "//media",
- "//media/base:test_support",
- "//testing/gmock",
- "//testing/gtest",
+ # TODO(alokp): Remove this dependency by refactoring
alokp 2016/12/15 22:37:56 This TODO has now been implemented in a separate p
+ # cma/pipeline/audio_video_pipeline_impl_unittest.cc
+ "//chromecast/media/cma/backend:default",
]
- if (chromecast_branding == "public") {
- # Link default libcast_media_1.0 statically not to link dummy one
- # dynamically for public unittests.
- deps += [ "//chromecast/media/base:libcast_media_1.0_default_core" ]
+ # MultizoneBackendTest verifies rendering delay reported by the backend.
+ # Since rendering delay is optional on video platforms, enable this test
+ # on audio devices only.
+ if (is_cast_audio_only) {
+ sources += [ "cma/backend/multizone_backend_unittest.cc" ]
}
}

Powered by Google App Engine
This is Rietveld 408576698