Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2508803012: [Chromecast] Android-specific cast_media implementation. (Closed)

Created:
4 years, 1 month ago by Simeon
Modified:
4 years ago
Reviewers:
slan, halliwell, AndyWu
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Android-specific cast_media implementation. Currently, this is a lazy copy of cast_media_dummy.cc, but with even less logic, always returning true from IsSupportedVideoConfig(). This is safe for now because CanDisplayType() does not check IsSupportedVideoConfig() until after it checks IsSupportedMediaFormat() and GetScreenResolution(), which on Android TV should cause CanDisplayType() to return false in all cases where IsSupportedVideoConfig() should return false. This is not guaranteed to hold in future releases, so a proper implementation should be made toute de suite. Test: 4K VP9 and HEVC playback works on foster and trinity. (Requires implementation of GetHDCPVersion() on Android) BUG=Internal b/32716650 Committed: https://crrev.com/50b301a8b31748d9642ff8e3226c240180fe10f4 Cr-Commit-Position: refs/heads/master@{#433626}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -1 line) Patch
M chromecast/media/base/BUILD.gn View 3 chunks +21 lines, -1 line 0 comments Download
A chromecast/media/base/cast_media_android.cc View 1 chunk +61 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Simeon
You have my permission to laugh at me for copy-pasting cast_media_dummy and making it even ...
4 years, 1 month ago (2016-11-19 01:10:53 UTC) #2
halliwell
On 2016/11/19 01:10:53, Simeon wrote: > You have my permission to laugh at me for ...
4 years, 1 month ago (2016-11-19 03:58:15 UTC) #3
AndyWu
lgtm
4 years, 1 month ago (2016-11-19 06:54:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2508803012/1
4 years ago (2016-11-21 17:44:54 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-21 20:24:24 UTC) #8
commit-bot: I haz the power
4 years ago (2016-11-21 20:29:08 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/50b301a8b31748d9642ff8e3226c240180fe10f4
Cr-Commit-Position: refs/heads/master@{#433626}

Powered by Google App Engine
This is Rietveld 408576698