Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Issue 257763009: Mojo: Fix incorrect PLOG in raw_channel_win.cc. (Closed)

Created:
6 years, 8 months ago by viettrungluu
Modified:
6 years, 8 months ago
Reviewers:
yzshen1
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo: Fix incorrect PLOG in raw_channel_win.cc. Oops. R=yzshen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266314

Patch Set 1 #

Total comments: 3

Patch Set 2 : aswefhjkl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M mojo/system/raw_channel_win.cc View 1 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
viettrungluu
6 years, 8 months ago (2014-04-25 20:00:42 UTC) #1
yzshen1
https://codereview.chromium.org/257763009/diff/1/mojo/system/raw_channel_win.cc File mojo/system/raw_channel_win.cc (right): https://codereview.chromium.org/257763009/diff/1/mojo/system/raw_channel_win.cc#newcode368 mojo/system/raw_channel_win.cc:368: LOG_IF(ERROR, error != ERROR_BROKEN_PIPE) << "ReadFile failed: " << ...
6 years, 8 months ago (2014-04-25 20:24:06 UTC) #2
viettrungluu
Thanks, PTAL. https://codereview.chromium.org/257763009/diff/1/mojo/system/raw_channel_win.cc File mojo/system/raw_channel_win.cc (right): https://codereview.chromium.org/257763009/diff/1/mojo/system/raw_channel_win.cc#newcode330 mojo/system/raw_channel_win.cc:330: LOG(ERROR) << "WriteFile failed: " << error; ...
6 years, 8 months ago (2014-04-25 20:58:01 UTC) #3
yzshen1
LGTM!
6 years, 8 months ago (2014-04-25 21:00:34 UTC) #4
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 8 months ago (2014-04-25 21:11:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/257763009/20001
6 years, 8 months ago (2014-04-25 22:01:43 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-25 23:39:54 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-25 23:39:54 UTC) #8
viettrungluu
6 years, 8 months ago (2014-04-26 01:27:01 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 manually as r266314 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698