Mojo: Fix incorrect PLOG in raw_channel_win.cc.

mojo/system/raw_channel_win.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/system/raw_channel.h"
 
 #include <windows.h>
 
 #include "base/auto_reset.h"
 #include "base/bind.h"
@@ skipping 280 matching lines @@
          base::MessageLoop::current() == owner_->message_loop_for_io());
   DCHECK(suppress_self_destruct_);
 
   CHECK(pending_read_);
   pending_read_ = false;
   if (!owner_)
     return;
 
   if (error != ERROR_SUCCESS) {
     DCHECK_EQ(bytes_read, 0u);
-    PLOG_IF(ERROR, error != ERROR_BROKEN_PIPE) << "ReadFile";
+    LOG_IF(ERROR, error != ERROR_BROKEN_PIPE)
+        << "ReadFile: " << logging::SystemErrorCodeToString(error);
     owner_->OnReadCompleted(false, 0);
   } else {
     DCHECK_GT(bytes_read, 0u);
     owner_->OnReadCompleted(true, bytes_read);
   }
 }
 
 void RawChannelWin::RawChannelIOHandler::OnWriteCompleted(DWORD bytes_written,
                                                           DWORD error) {
   DCHECK(!owner_ ||
          base::MessageLoop::current() == owner_->message_loop_for_io());
   DCHECK(suppress_self_destruct_);
 
   if (!owner_) {
     // No lock needed.
     CHECK(pending_write_);
     pending_write_ = false;
     return;
   }
 
   {
     base::AutoLock locker(owner_->write_lock());
     CHECK(pending_write_);
     pending_write_ = false;
   }
 
   if (error != ERROR_SUCCESS) {
     LOG(ERROR) << "WriteFile failed: " << error;

[viettrungluu, 2014/04/25 20:58:01]

Done here too.

     owner_->OnWriteCompleted(false, 0);
   } else {
     owner_->OnWriteCompleted(true, bytes_written);
   }
 }
 
 RawChannelWin::RawChannelWin(embedder::ScopedPlatformHandle handle)
     : handle_(handle.Pass()),
       io_handler_(NULL),
       skip_completion_port_on_success_(
@@ skipping 17 matching lines @@
   DWORD bytes_read_dword = 0;
   BOOL result = ReadFile(io_handler_->handle(),
                          buffer,
                          static_cast<DWORD>(bytes_to_read),
                          &bytes_read_dword,
                          &io_handler_->read_context()->overlapped);
   if (!result) {
     DCHECK_EQ(bytes_read_dword, 0u);
     DWORD error = GetLastError();
     if (error != ERROR_IO_PENDING) {
       LOG_IF(ERROR, error != ERROR_BROKEN_PIPE) << "ReadFile failed: " << error;

[yzshen1, 2014/04/25 20:24:07]

Maybe we could output the same info here, using
logging::SystemErrorCodeToString()?

[viettrungluu, 2014/04/25 20:58:01]

Done.

       return IO_FAILED;
     }
   }
 
   if (result && skip_completion_port_on_success_) {
     *bytes_read = bytes_read_dword;
     return IO_SUCCEEDED;
   }
 
   // If the read is pending or the read has succeeded but we don't skip
@@ skipping 149 matching lines @@
 
 // Static factory method declared in raw_channel.h.
 // static
 scoped_ptr<RawChannel> RawChannel::Create(
     embedder::ScopedPlatformHandle handle) {
   return scoped_ptr<RawChannel>(new RawChannelWin(handle.Pass()));
 }
 
 }  // namespace system
 }  // namespace mojo