Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(971)

Unified Diff: mojo/system/raw_channel_win.cc

Issue 257763009: Mojo: Fix incorrect PLOG in raw_channel_win.cc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: aswefhjkl Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/system/raw_channel_win.cc
diff --git a/mojo/system/raw_channel_win.cc b/mojo/system/raw_channel_win.cc
index 8568e8e7317e3a000784d7b48173b2e44cc5a76b..fe776ea60e59605a4a28ada74909b2cc706e6434 100644
--- a/mojo/system/raw_channel_win.cc
+++ b/mojo/system/raw_channel_win.cc
@@ -298,7 +298,8 @@ void RawChannelWin::RawChannelIOHandler::OnReadCompleted(DWORD bytes_read,
if (error != ERROR_SUCCESS) {
DCHECK_EQ(bytes_read, 0u);
- PLOG_IF(ERROR, error != ERROR_BROKEN_PIPE) << "ReadFile";
+ LOG_IF(ERROR, error != ERROR_BROKEN_PIPE)
+ << "ReadFile: " << logging::SystemErrorCodeToString(error);
owner_->OnReadCompleted(false, 0);
} else {
DCHECK_GT(bytes_read, 0u);
@@ -326,7 +327,7 @@ void RawChannelWin::RawChannelIOHandler::OnWriteCompleted(DWORD bytes_written,
}
if (error != ERROR_SUCCESS) {
- LOG(ERROR) << "WriteFile failed: " << error;
+ LOG(ERROR) << "WriteFile: " << logging::SystemErrorCodeToString(error);
owner_->OnWriteCompleted(false, 0);
} else {
owner_->OnWriteCompleted(true, bytes_written);
@@ -364,7 +365,8 @@ RawChannel::IOResult RawChannelWin::Read(size_t* bytes_read) {
DCHECK_EQ(bytes_read_dword, 0u);
DWORD error = GetLastError();
if (error != ERROR_IO_PENDING) {
- LOG_IF(ERROR, error != ERROR_BROKEN_PIPE) << "ReadFile failed: " << error;
+ LOG_IF(ERROR, error != ERROR_BROKEN_PIPE)
+ << "ReadFile: " << logging::SystemErrorCodeToString(error);
return IO_FAILED;
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698