Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(912)

Issue 2577583002: Rename NavigationHandle::GetRequestContextType to request_context_type. (Closed)

Created:
4 years ago by carlosk
Modified:
4 years ago
Reviewers:
nasko
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename NavigationHandle::GetRequestContextType to request_context_type. At some point during discussions of the browser side mixed-content move patch (https://crrev.com/1905033002) it was suggested that this getter was doing just a simple value return and so it should be renamed accordingly. This spin off change does that. BUG=576270 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/a954e94f97ea0721925ceac05764e57e020f9493 Cr-Commit-Position: refs/heads/master@{#438905}

Patch Set 1 #

Patch Set 2 : Moved implementation to header file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -13 lines) Patch
M content/browser/frame_host/navigation_handle_impl.h View 1 1 chunk +4 lines, -1 line 0 comments Download
M content/browser/frame_host/navigation_handle_impl.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/frame_host/navigation_handle_impl_browsertest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/frame_host/navigation_handle_impl_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 22 (16 generated)
carlosk
nasko@: PTAL.
4 years ago (2016-12-14 03:17:31 UTC) #9
carlosk
Updated description to reflect reality, which is the complete opposite of what I said before. ...
4 years ago (2016-12-15 01:52:19 UTC) #14
nasko
LGTM
4 years ago (2016-12-15 18:45:35 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2577583002/40001
4 years ago (2016-12-15 18:54:31 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years ago (2016-12-15 20:12:10 UTC) #20
commit-bot: I haz the power
4 years ago (2016-12-15 20:15:31 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a954e94f97ea0721925ceac05764e57e020f9493
Cr-Commit-Position: refs/heads/master@{#438905}

Powered by Google App Engine
This is Rietveld 408576698