Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Side by Side Diff: content/browser/frame_host/navigation_handle_impl.h

Issue 2577583002: Rename NavigationHandle::GetRequestContextType to request_context_type. (Closed)
Patch Set: Moved implementation to header file. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/frame_host/navigation_handle_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_HANDLE_IMPL_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_HANDLE_IMPL_H_
6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_HANDLE_IMPL_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_HANDLE_IMPL_H_
7 7
8 #include "content/public/browser/navigation_handle.h" 8 #include "content/public/browser/navigation_handle.h"
9 9
10 #include <stddef.h> 10 #include <stddef.h>
(...skipping 132 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 // created during a navigation to an interstitial page. In this case it will 143 // created during a navigation to an interstitial page. In this case it will
144 // be the InterstitialPage itself. 144 // be the InterstitialPage itself.
145 // 145 //
146 // Note: due to the interstitial navigation case, all calls that can possibly 146 // Note: due to the interstitial navigation case, all calls that can possibly
147 // expose the NavigationHandle to code outside of content/ MUST go though the 147 // expose the NavigationHandle to code outside of content/ MUST go though the
148 // NavigatorDelegate. In particular, the ContentBrowserClient should not be 148 // NavigatorDelegate. In particular, the ContentBrowserClient should not be
149 // called directly form the NavigationHandle code. Thus, these calls will not 149 // called directly form the NavigationHandle code. Thus, these calls will not
150 // expose the NavigationHandle when navigating to an InterstialPage. 150 // expose the NavigationHandle when navigating to an InterstialPage.
151 NavigatorDelegate* GetDelegate() const; 151 NavigatorDelegate* GetDelegate() const;
152 152
153 RequestContextType GetRequestContextType() const; 153 RequestContextType request_context_type() const {
154 DCHECK_GE(state_, WILL_SEND_REQUEST);
155 return request_context_type_;
156 }
154 157
155 // Get the unique id from the NavigationEntry associated with this 158 // Get the unique id from the NavigationEntry associated with this
156 // NavigationHandle. Note that a synchronous, renderer-initiated navigation 159 // NavigationHandle. Note that a synchronous, renderer-initiated navigation
157 // will not have a NavigationEntry associated with it, and this will return 0. 160 // will not have a NavigationEntry associated with it, and this will return 0.
158 int pending_nav_entry_id() const { return pending_nav_entry_id_; } 161 int pending_nav_entry_id() const { return pending_nav_entry_id_; }
159 162
160 // Changes the pending NavigationEntry ID for this handle. This is currently 163 // Changes the pending NavigationEntry ID for this handle. This is currently
161 // required during transfer navigations. 164 // required during transfer navigations.
162 // TODO(creis): Remove this when transfer navigations do not require pending 165 // TODO(creis): Remove this when transfer navigations do not require pending
163 // entries. See https://crbug.com/495161. 166 // entries. See https://crbug.com/495161.
(...skipping 277 matching lines...) Expand 10 before | Expand all | Expand 10 after
441 std::string searchable_form_encoding_; 444 std::string searchable_form_encoding_;
442 445
443 base::WeakPtrFactory<NavigationHandleImpl> weak_factory_; 446 base::WeakPtrFactory<NavigationHandleImpl> weak_factory_;
444 447
445 DISALLOW_COPY_AND_ASSIGN(NavigationHandleImpl); 448 DISALLOW_COPY_AND_ASSIGN(NavigationHandleImpl);
446 }; 449 };
447 450
448 } // namespace content 451 } // namespace content
449 452
450 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_HANDLE_IMPL_H_ 453 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_HANDLE_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | content/browser/frame_host/navigation_handle_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698