Add struct traits for base::Value.

Add struct traits for base::Value.

BUG=675860
Committed: https://crrev.com/9bd0ed45ad35ed78c4ccd55321f884cacd0778d7
Cr-Commit-Position: refs/heads/master@{#440057}

[Sam McNally, 2016-12-13 23:15:27]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 23:16:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 23:21:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 23:21:44]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Sam McNally, 2016-12-14 01:30:29]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 01:31:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 01:55:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 01:55:31]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[Sam McNally, 2016-12-14 02:40:56]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 02:41:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-12-14 02:42:31]

Patchset #3 (id:40001) has been deleted

[Sam McNally, 2016-12-14 02:42:49]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 02:43:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 03:03:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 03:03:20]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sam McNally, 2016-12-14 07:23:01]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 07:23:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 07:44:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 07:44:51]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Sam McNally, 2016-12-14 23:59:01]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 23:59:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-12-15 01:55:52]

Patchset #1 (id:1) has been deleted

[Sam McNally, 2016-12-15 01:56:06]

Patchset #1 (id:20001) has been deleted

[Sam McNally, 2016-12-15 01:56:10]

Patchset #1 (id:60001) has been deleted

[Sam McNally, 2016-12-15 01:56:37]

Patchset #1 (id:80001) has been deleted

[Sam McNally, 2016-12-15 02:05:32]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 02:05:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 02:10:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 02:10:55]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Sam McNally, 2016-12-15 03:26:46]

Patchset #1 (id:100001) has been deleted

[Sam McNally, 2016-12-15 03:28:01]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 03:28:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 05:07:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 05:07:23]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2016-12-15 06:31:42]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 06:31:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 07:34:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 07:34:59]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Sam McNally, 2016-12-15 10:32:14]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 10:32:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 14:08:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 14:08:21]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2016-12-15 22:44:57]

Patchset #2 (id:140001) has been deleted

[Sam McNally, 2016-12-15 22:44:59]

Patchset #1 (id:120001) has been deleted

[Sam McNally, 2016-12-15 22:49:18]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 22:50:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-12-15 22:59:45]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 23:00:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-12-15 23:00:04]

Patchset #1 (id:160001) has been deleted

[Sam McNally, 2016-12-15 23:00:07]

Patchset #1 (id:180001) has been deleted

[Sam McNally, 2016-12-16 00:05:50]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 00:06:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 03:05:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 03:05:43]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sam McNally, 2016-12-16 03:17:33]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 03:18:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-12-16 04:23:02]

sammc@chromium.org changed reviewers:
+ dcheng@chromium.org, rockot@chromium.org

[Sam McNally, 2016-12-16 04:23:04]

+dcheng for //base, the mojoms and struct traits

+rockot for //mojo and //services

[commit-bot: I haz the power, 2016-12-16 07:47:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 07:47:29]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ken Rockot(use gerrit already), 2016-12-16 16:39:58]

lgtm

https://codereview.chromium.org/2577563002/diff/220001/mojo/common/values.mojom
File mojo/common/values.mojom (right):

https://codereview.chromium.org/2577563002/diff/220001/mojo/common/values.moj...
mojo/common/values.mojom:31: struct LegacyListValue;
Can we add a TODO to remote this ASAP?

[dcheng, 2016-12-16 18:00:45]

dcheng@chromium.org changed reviewers:
+ tsepez@chromium.org

[dcheng, 2016-12-16 18:00:46]

Hmm... my understanding is it was an intentional decision not to support generic
base::Value in ParamTraits, and only support DictionaryValue / ListValue.

If we want non-native structs though, I don't see how we can avoid that.
+tsepez, do you happen to remember more of the background on this?

[Ken Rockot(use gerrit already), 2016-12-16 18:06:53]

I don't recall it being an intentional decision, rather I thought it was
just more work than necessary at the time, since only DictionaryValue and
ListValue were needed.

The CL which added the typemap is here
<https://codereview.chromium.org/2013433002>. I suppose it predates our
having security owners on all mojom review.

On Fri, Dec 16, 2016 at 10:00 AM, <dcheng@chromium.org> wrote:

> Hmm... my understanding is it was an intentional decision not to support
> generic
> base::Value in ParamTraits, and only support DictionaryValue / ListValue.
>
> If we want non-native structs though, I don't see how we can avoid that.
> +tsepez, do you happen to remember more of the background on this?
>
> https://codereview.chromium.org/2577563002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Tom Sepez, 2016-12-16 18:16:51]

This was an intentional decision not to do this.  Now I need to go look up the
rationale.  Hang on. In the mean time, not lgtm. Sorry.

[Tom Sepez, 2016-12-16 18:20:31]

On 2016/12/16 18:16:51, Tom Sepez wrote:
> This was an intentional decision not to do this.  Now I need to go look up the
> rationale.  Hang on. In the mean time, not lgtm. Sorry.

See https://codereview.chromium.org/2474783004/.  Generally, we just wrap the
top-level item in a dictionary, which allows us to get the process going based
upon an object of known size.

[Ken Rockot(use gerrit already), 2016-12-16 18:26:50]

On 2016/12/16 at 18:20:31, tsepez wrote:
> On 2016/12/16 18:16:51, Tom Sepez wrote:
> > This was an intentional decision not to do this.  Now I need to go look up
the
> > rationale.  Hang on. In the mean time, not lgtm. Sorry.
> 
> See https://codereview.chromium.org/2474783004/.  Generally, we just wrap the
top-level item in a dictionary, which allows us to get the process going based
upon an object of known size.

Sorry, I don't follow the rationale here. Could you please explain why it's
problematic to typemap base::Value to an equivalent mojom union?

[yzshen1, 2016-12-16 18:40:35]

On 2016/12/16 18:20:31, Tom Sepez wrote:
> On 2016/12/16 18:16:51, Tom Sepez wrote:
> > This was an intentional decision not to do this.  Now I need to go look up
the
> > rationale.  Hang on. In the mean time, not lgtm. Sorry.
> 
> See https://codereview.chromium.org/2474783004/.  Generally, we just wrap the
> top-level item in a dictionary, which allows us to get the process going based
> upon an object of known size.

I looked at 2474783004 but I am still not sure about the exact reasons why
generic values were not allowed in IPC. Would you please elaborate?

[Tom Sepez, 2016-12-16 19:08:57]

I think we decided it was more work than needed to accomplish what anyone needed
to do.

[Tom Sepez, 2016-12-16 19:15:09]

On 2016/12/16 19:08:57, Tom Sepez wrote:
> I think we decided it was more work than needed to accomplish what anyone
needed
> to do.

Though I think we can reverse that, since this is the second time we've hit
this.
LGTM.

[Sam McNally, 2016-12-18 22:43:34]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-18 22:43:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-12-18 23:18:31]

sammc@chromium.org changed reviewers:
+ bauerb@chromium.org, chcunningham@chromium.org, jochen@chromium.org

[Sam McNally, 2016-12-18 23:18:31]

+chcunningham for //media and //content/*/media

+bauerb for //components/safe_json

+jochen for //chrome and //components/typemaps.gni

https://codereview.chromium.org/2577563002/diff/220001/mojo/common/values.mojom
File mojo/common/values.mojom (right):

https://codereview.chromium.org/2577563002/diff/220001/mojo/common/values.moj...
mojo/common/values.mojom:31: struct LegacyListValue;
On 2016/12/16 16:39:57, Ken Rockot (OOO back Dec 27) wrote:
> Can we add a TODO to remote this ASAP?

Done.

[commit-bot: I haz the power, 2016-12-19 01:40:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 01:40:17]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2016-12-19 10:42:23]

safe_json LGTM

[jochen (gone - plz use gerrit), 2016-12-19 11:57:02]

please add a tracking bug for this and reference it from the CL description.

Ideally, the bug would also block whatever other feature work depends on it. As
is, it's hard to understand what the motivation for this change is.

with the bug in place and referenced, chrome/ and typemap.gni lgtm

[Sam McNally, 2016-12-19 22:34:39]

Description was changed from

==========
Add struct traits for base::Value.
==========

to

==========
Add struct traits for base::Value.

BUG=654988
==========

[Sam McNally, 2016-12-20 06:11:51]

Description was changed from

==========
Add struct traits for base::Value.

BUG=654988
==========

to

==========
Add struct traits for base::Value.

BUG=675860
==========

[Sam McNally, 2016-12-20 06:22:06]

On 2016/12/19 11:57:02, jochen wrote:
> please add a tracking bug for this and reference it from the CL description.
> 
> Ideally, the bug would also block whatever other feature work depends on it.
As
> is, it's hard to understand what the motivation for this change is.
> 
> with the bug in place and referenced, chrome/ and typemap.gni lgtm

Done.

[chcunningham, 2016-12-20 18:43:42]

media LGTM

[Sam McNally, 2016-12-20 21:09:45]

dcheng: still need your review for //base.

[dcheng, 2016-12-20 23:44:47]

I'm not super enthusiastic about the new base interface. I really wish mojo
didn't have to call each getter twice, since it's a bit unexpected, and has
surprised people a number of times already.

https://codereview.chromium.org/2577563002/diff/260001/media/base/video_frame...
File media/base/video_frame_metadata.cc (right):

https://codereview.chromium.org/2577563002/diff/260001/media/base/video_frame...
media/base/video_frame_metadata.cc:154: std::unique_ptr<base::DictionaryValue>
VideoFrameMetadata::CopyInternalValues()
It's a bit unfortunate that we have to copy now, just to serialize for IPC.

[dcheng, 2016-12-20 23:44:58]

(this cl lgtm though)

[Sam McNally, 2016-12-21 00:16:16]

https://codereview.chromium.org/2577563002/diff/260001/media/base/video_frame...
File media/base/video_frame_metadata.cc (right):

https://codereview.chromium.org/2577563002/diff/260001/media/base/video_frame...
media/base/video_frame_metadata.cc:154: std::unique_ptr<base::DictionaryValue>
VideoFrameMetadata::CopyInternalValues()
On 2016/12/20 23:44:47, dcheng wrote:
> It's a bit unfortunate that we have to copy now, just to serialize for IPC.

Yes, but it's no worse than before. Merging the dictionary copied the contents
into |out|.

[Sam McNally, 2016-12-21 00:16:37]

The CQ bit was checked by sammc@chromium.org

[Sam McNally, 2016-12-21 00:16:37]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2577563002/#ps260001
(title: " ")

[commit-bot: I haz the power, 2016-12-21 00:17:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 02:19:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 02:19:21]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sam McNally, 2016-12-21 02:22:32]

The CQ bit was checked by sammc@chromium.org

[commit-bot: I haz the power, 2016-12-21 02:23:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2016-12-21 02:23:04]

https://codereview.chromium.org/2577563002/diff/260001/mojo/common/values.mojom
File mojo/common/values.mojom (right):

https://codereview.chromium.org/2577563002/diff/260001/mojo/common/values.moj...
mojo/common/values.mojom:8: NullValue? null_value;
Btw, why does this need to be nullable?

[Sam McNally, 2016-12-21 02:32:53]

https://codereview.chromium.org/2577563002/diff/260001/mojo/common/values.mojom
File mojo/common/values.mojom (right):

https://codereview.chromium.org/2577563002/diff/260001/mojo/common/values.moj...
mojo/common/values.mojom:8: NullValue? null_value;
On 2016/12/21 02:23:04, dcheng wrote:
> Btw, why does this need to be nullable?

It's so the traits can return a null NullValuePtr instead of creating a real
NullValue. The receiver ignores it so a null value is fine.

[commit-bot: I haz the power, 2016-12-21 06:14:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 06:14:41]

Failed to apply patch for components/typemaps.gni:
While running git apply --index -p1;
  error: patch failed: components/typemaps.gni:5
  error: components/typemaps.gni: patch does not apply

Patch:       components/typemaps.gni
Index: components/typemaps.gni
diff --git a/components/typemaps.gni b/components/typemaps.gni
index
da1f6d9a1cc567aec31aca02d0a0c8cd0f70fa8a..305f9f3fb88335afbb4acd9cb0351fd9efa6e309
100644
--- a/components/typemaps.gni
+++ b/components/typemaps.gni
@@ -5,6 +5,5 @@
 typemaps = [
   "//components/autofill/content/common/autofill_types.typemap",
   "//components/password_manager/content/common/credential_manager.typemap",
-  "//components/safe_json/public/interfaces/safe_json.typemap",
   "//components/translate/content/common/translate.typemap",
 ]

[Sam McNally, 2016-12-21 06:50:15]

The CQ bit was checked by sammc@chromium.org

[Sam McNally, 2016-12-21 06:50:15]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
rockot@chromium.org, jochen@chromium.org, dcheng@chromium.org,
chcunningham@chromium.org, tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2577563002/#ps280001
(title: "rebase")

[commit-bot: I haz the power, 2016-12-21 06:50:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 08:55:45]

CQ is committing da patch.

Bot data: {"patchset_id": 280001, "attempt_start_ts": 1482303015180410,
"parent_rev": "accc951a263f39a9eecf39aee67aaa9e0fa07aef", "commit_rev":
"76545ab44ca836a4338a28d879d08a1a3ab9d84e"}

[commit-bot: I haz the power, 2016-12-21 08:56:16]

Description was changed from

==========
Add struct traits for base::Value.

BUG=675860
==========

to

==========
Add struct traits for base::Value.

BUG=675860

Review-Url: https://codereview.chromium.org/2577563002
==========

[commit-bot: I haz the power, 2016-12-21 08:56:18]

Committed patchset #5 (id:280001)

[commit-bot: I haz the power, 2016-12-21 08:59:44]

Description was changed from

==========
Add struct traits for base::Value.

BUG=675860

Review-Url: https://codereview.chromium.org/2577563002
==========

to

==========
Add struct traits for base::Value.

BUG=675860

Committed: https://crrev.com/9bd0ed45ad35ed78c4ccd55321f884cacd0778d7
Cr-Commit-Position: refs/heads/master@{#440057}
==========

[commit-bot: I haz the power, 2016-12-21 08:59:46]

Patchset 5 (id:??) landed as
https://crrev.com/9bd0ed45ad35ed78c4ccd55321f884cacd0778d7
Cr-Commit-Position: refs/heads/master@{#440057}