services/preferences/public/cpp/pref_observer_store.h - Issue 2577563002: Add struct traits for base::Value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/preferences/public/cpp/pref_observer_store.h

Issue 2577563002: Add struct traits for base::Value. (Closed)

Patch Set: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: services/preferences/public/cpp/pref_observer_store.h

diff --git a/services/preferences/public/cpp/pref_observer_store.h b/services/preferences/public/cpp/pref_observer_store.h

index c8af343ba06f23d3ab45883e0aaca068fa9ede55..ea474600b4b41de7d3fea5ba259dc3384a24794a 100644

--- a/services/preferences/public/cpp/pref_observer_store.h

+++ b/services/preferences/public/cpp/pref_observer_store.h

@@ -61,7 +61,8 @@ class PrefObserverStore : public ValueMapPrefStore,

base::Value const & value);

// prefs::mojom::PreferenceObserver:

- void OnPreferencesChanged(const base::DictionaryValue& preferences) override;

+ void OnPreferencesChanged(

+ std::unique_ptr<base::DictionaryValue> preferences) override;

mojo::Binding<prefs::mojom::PreferencesObserver> prefs_binding_;

prefs::mojom::PreferencesManagerPtr prefs_manager_ptr_;