Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issue 2577443002: Revert of [ObjC ARC] Converts ios/chrome/browser/ui/autofill:autofill to ARC. (Closed)

Created:
4 years ago by Olivier
Modified:
4 years ago
CC:
chromium-reviews, rouslan+autofill_chromium.org, sebsg+autofillwatch_chromium.org, pkl (ping after 24h if needed), jdonnelly+autofillwatch_chromium.org, mathp+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [ObjC ARC] Converts ios/chrome/browser/ui/autofill:autofill to ARC. (patchset #3 id:40001 of https://codereview.chromium.org/2569713003/ ) Reason for revert: Breaks compilation of autofill_controller_unittest.mm Original issue's description: > [ObjC ARC] Converts ios/chrome/browser/ui/autofill:autofill to ARC. > > Automatically generated ARCMigrate commit > Notable issues:None > BUG=624363 > TEST=None > > Committed: https://crrev.com/01e99d0af3a84ae96857d34e096ff4f876e56c2a > Cr-Commit-Position: refs/heads/master@{#438167} TBR=noyau@chromium.org,stkhapugin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=624363 Committed: https://crrev.com/22a19daeda2f1b2183cf3d2d6dd6a96744d3f01e Cr-Commit-Position: refs/heads/master@{#438188}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -10 lines) Patch
M ios/chrome/browser/ui/autofill/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/autofill/autofill_client_ios.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/autofill/autofill_client_ios.mm View 2 chunks +1 line, -4 lines 0 comments Download
M ios/chrome/browser/ui/autofill/autofill_save_card_infobar.mm View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Olivier
Created Revert of [ObjC ARC] Converts ios/chrome/browser/ui/autofill:autofill to ARC.
4 years ago (2016-12-13 16:28:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2577443002/1
4 years ago (2016-12-13 16:28:58 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 16:30:14 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-13 16:33:35 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/22a19daeda2f1b2183cf3d2d6dd6a96744d3f01e
Cr-Commit-Position: refs/heads/master@{#438188}

Powered by Google App Engine
This is Rietveld 408576698