Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2569713003: [ObjC ARC] Converts ios/chrome/browser/ui/autofill:autofill to ARC. (Closed)

Created:
4 years ago by stkhapugin
Modified:
4 years ago
CC:
chromium-reviews, rouslan+autofill_chromium.org, sebsg+autofillwatch_chromium.org, pkl (ping after 24h if needed), jdonnelly+autofillwatch_chromium.org, mathp+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/autofill:autofill to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Committed: https://crrev.com/01e99d0af3a84ae96857d34e096ff4f876e56c2a Cr-Commit-Position: refs/heads/master@{#438167}

Patch Set 1 #

Patch Set 2 : asdf #

Total comments: 2

Patch Set 3 : comment_removed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M ios/chrome/browser/ui/autofill/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/autofill/autofill_client_ios.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/autofill/autofill_client_ios.mm View 2 chunks +4 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/autofill/autofill_save_card_infobar.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
stkhapugin
PTAL
4 years ago (2016-12-12 18:23:42 UTC) #4
noyau (Ping after 24h)
lgtm https://codereview.chromium.org/2569713003/diff/20001/ios/chrome/browser/ui/autofill/autofill_client_ios.h File ios/chrome/browser/ui/autofill/autofill_client_ios.h (right): https://codereview.chromium.org/2569713003/diff/20001/ios/chrome/browser/ui/autofill/autofill_client_ios.h#newcode99 ios/chrome/browser/ui/autofill/autofill_client_ios.h:99: __weak id<AutofillClientIOSBridge> bridge_; // Weak Remove the // ...
4 years ago (2016-12-13 12:20:46 UTC) #5
stkhapugin
https://codereview.chromium.org/2569713003/diff/20001/ios/chrome/browser/ui/autofill/autofill_client_ios.h File ios/chrome/browser/ui/autofill/autofill_client_ios.h (right): https://codereview.chromium.org/2569713003/diff/20001/ios/chrome/browser/ui/autofill/autofill_client_ios.h#newcode99 ios/chrome/browser/ui/autofill/autofill_client_ios.h:99: __weak id<AutofillClientIOSBridge> bridge_; // Weak On 2016/12/13 12:20:46, noyau ...
4 years ago (2016-12-13 13:37:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2569713003/40001
4 years ago (2016-12-13 13:38:43 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-13 15:00:07 UTC) #12
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/01e99d0af3a84ae96857d34e096ff4f876e56c2a Cr-Commit-Position: refs/heads/master@{#438167}
4 years ago (2016-12-13 15:02:02 UTC) #14
Olivier
4 years ago (2016-12-13 16:28:23 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2577443002/ by olivierrobin@chromium.org.

The reason for reverting is: Breaks compilation of
autofill_controller_unittest.mm.

Powered by Google App Engine
This is Rietveld 408576698