Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2577333002: Created file-based test pages for window.location tests. (Closed)

Created:
4 years ago by kkhorimoto
Modified:
3 years, 11 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Created file-based test page for window.location tests. BUG=673022 Review-Url: https://codereview.chromium.org/2577333002 Cr-Commit-Position: refs/heads/master@{#444108} Committed: https://chromium.googlesource.com/chromium/src/+/401cb387efc0236740281366d2c959f443022ee1

Patch Set 1 #

Total comments: 4

Patch Set 2 : URL => Url #

Patch Set 3 : added functions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -0 lines) Patch
M ios/testing/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A ios/testing/data/http_server_files/window_location.html View 1 chunk +31 lines, -0 lines 0 comments Download
A ios/testing/data/http_server_files/window_location.js View 1 2 1 chunk +49 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
kkhorimoto
4 years ago (2016-12-16 03:14:32 UTC) #2
Eugene But (OOO till 7-30)
lgtm https://codereview.chromium.org/2577333002/diff/1/ios/testing/data/http_server_files/window_location.js File ios/testing/data/http_server_files/window_location.js (right): https://codereview.chromium.org/2577333002/diff/1/ios/testing/data/http_server_files/window_location.js#newcode14 ios/testing/data/http_server_files/window_location.js:14: var updateURLToLoadText = function(text) { nit: s/URL/Url per ...
4 years ago (2016-12-16 03:38:11 UTC) #3
kkhorimoto
https://codereview.chromium.org/2577333002/diff/1/ios/testing/data/http_server_files/window_location.js File ios/testing/data/http_server_files/window_location.js (right): https://codereview.chromium.org/2577333002/diff/1/ios/testing/data/http_server_files/window_location.js#newcode14 ios/testing/data/http_server_files/window_location.js:14: var updateURLToLoadText = function(text) { On 2016/12/16 03:38:11, Eugene ...
4 years ago (2016-12-20 23:23:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2577333002/40001
3 years, 11 months ago (2017-01-17 18:18:19 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 19:24:53 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/401cb387efc0236740281366d2c9...

Powered by Google App Engine
This is Rietveld 408576698