Created test for window.location.assign.

Created test for window.location.assign.

BUG=673022
Review-Url: https://codereview.chromium.org/2599233002
Cr-Commit-Position: refs/heads/master@{#444227}
Committed: https://chromium.googlesource.com/chromium/src/+/ce346ca4212bde35cb9628da2314de326c69ebca

[kkhorimoto, 2016-12-23 01:32:34]

kkhorimoto@chromium.org changed reviewers:
+ eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2016-12-23 01:53:35]

lgtm

https://codereview.chromium.org/2599233002/diff/20001/ios/web/navigation/wind...
File ios/web/navigation/window_location_inttest.mm (right):

https://codereview.chromium.org/2599233002/diff/20001/ios/web/navigation/wind...
ios/web/navigation/window_location_inttest.mm:10: #include
"ios/web/public/navigation_item.h"
import

https://codereview.chromium.org/2599233002/diff/20001/ios/web/navigation/wind...
ios/web/navigation/window_location_inttest.mm:11: #include
"ios/web/public/navigation_manager.h"
import

https://codereview.chromium.org/2599233002/diff/20001/ios/web/navigation/wind...
ios/web/navigation/window_location_inttest.mm:15: #include
"ios/web/public/web_state/web_state.h"
import

https://codereview.chromium.org/2599233002/diff/20001/ios/web/navigation/wind...
ios/web/navigation/window_location_inttest.mm:78: bool page_loaded_;
bool page_loaded_ = false;

https://codereview.chromium.org/2599233002/diff/20001/ios/web/navigation/wind...
ios/web/navigation/window_location_inttest.mm:83: class WindowLocationTest :
public web::WebIntTest {
Do you need comment here?

https://codereview.chromium.org/2599233002/diff/20001/ios/web/navigation/wind...
ios/web/navigation/window_location_inttest.mm:97: web::WebState::CreateParams
webStateCreateParams(GetBrowserState());
web_state_create_params

https://codereview.chromium.org/2599233002/diff/20001/ios/web/navigation/wind...
ios/web/navigation/window_location_inttest.mm:150:
web_state()->ExecuteJavaScript(
There is web::ExecuteJavaScript test method which synchronously returns the
result. Using it here will simplify the code.

https://codereview.chromium.org/2599233002/diff/20001/ios/web/navigation/wind...
ios/web/navigation/window_location_inttest.mm:168:
web_state()->ExecuteJavaScript(
ditto

[kkhorimoto, 2017-01-18 00:09:34]

https://codereview.chromium.org/2599233002/diff/20001/ios/web/navigation/wind...
File ios/web/navigation/window_location_inttest.mm (right):

https://codereview.chromium.org/2599233002/diff/20001/ios/web/navigation/wind...
ios/web/navigation/window_location_inttest.mm:10: #include
"ios/web/public/navigation_item.h"
On 2016/12/23 01:53:35, Eugene But wrote:
> import

Done.

https://codereview.chromium.org/2599233002/diff/20001/ios/web/navigation/wind...
ios/web/navigation/window_location_inttest.mm:11: #include
"ios/web/public/navigation_manager.h"
On 2016/12/23 01:53:34, Eugene But wrote:
> import

Done.

https://codereview.chromium.org/2599233002/diff/20001/ios/web/navigation/wind...
ios/web/navigation/window_location_inttest.mm:15: #include
"ios/web/public/web_state/web_state.h"
On 2016/12/23 01:53:35, Eugene But wrote:
> import

Done.

https://codereview.chromium.org/2599233002/diff/20001/ios/web/navigation/wind...
ios/web/navigation/window_location_inttest.mm:78: bool page_loaded_;
On 2016/12/23 01:53:35, Eugene But wrote:
> bool page_loaded_ = false;

The default value is already set in the constructor's initialization list.

https://codereview.chromium.org/2599233002/diff/20001/ios/web/navigation/wind...
ios/web/navigation/window_location_inttest.mm:83: class WindowLocationTest :
public web::WebIntTest {
On 2016/12/23 01:53:35, Eugene But wrote:
> Do you need comment here?

Done.

https://codereview.chromium.org/2599233002/diff/20001/ios/web/navigation/wind...
ios/web/navigation/window_location_inttest.mm:97: web::WebState::CreateParams
webStateCreateParams(GetBrowserState());
On 2016/12/23 01:53:35, Eugene But wrote:
> web_state_create_params

Done.

https://codereview.chromium.org/2599233002/diff/20001/ios/web/navigation/wind...
ios/web/navigation/window_location_inttest.mm:150:
web_state()->ExecuteJavaScript(
On 2016/12/23 01:53:35, Eugene But wrote:
> There is web::ExecuteJavaScript test method which synchronously returns the
> result. Using it here will simplify the code.

Done.

https://codereview.chromium.org/2599233002/diff/20001/ios/web/navigation/wind...
ios/web/navigation/window_location_inttest.mm:168:
web_state()->ExecuteJavaScript(
On 2016/12/23 01:53:34, Eugene But wrote:
> ditto

Done.

[kkhorimoto, 2017-01-18 00:09:37]

The CQ bit was checked by kkhorimoto@chromium.org

[kkhorimoto, 2017-01-18 00:09:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2599233002/#ps40001
(title: "move shared code to WebIntTest")

[commit-bot: I haz the power, 2017-01-18 00:10:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 01:27:33]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484698177556350,
"parent_rev": "849cf351ba77ea929f2d850f5df99ca2fbdcb6b0", "commit_rev":
"ce346ca4212bde35cb9628da2314de326c69ebca"}

[commit-bot: I haz the power, 2017-01-18 01:28:32]

Description was changed from

==========
Created test for window.location.assign.

BUG=673022
==========

to

==========
Created test for window.location.assign.

BUG=673022

Review-Url: https://codereview.chromium.org/2599233002
Cr-Commit-Position: refs/heads/master@{#444227}
Committed:
https://chromium.googlesource.com/chromium/src/+/ce346ca4212bde35cb9628da2314...
==========

[commit-bot: I haz the power, 2017-01-18 01:28:32]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ce346ca4212bde35cb9628da2314...