Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 2577303002: [Downloads] DownloadNotificationService action fallback (Closed)

Created:
4 years ago by gone
Modified:
4 years ago
Reviewers:
Theresa
CC:
chromium-reviews, asanka, agrieve+watch_chromium.org, qinmin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Downloads] DownloadNotificationService action fallback DownloadNotificationService lags behind Download Home on learning about downloads that exist. Problematically, Download Home needs to act on downloads via DownloadNotificationService to ensure that notifications properly account for download updates. Currently, when DownloadNotificationService is told to do something for a download it doesn't know about, the Intent is dropped on the floor. Instead, fall back so that the DownloadManagerService is notified by DownloadNotificationService about actions triggered via Download Home. BUG=673994, 658246 Committed: https://crrev.com/464f8dff920bd0b33f58e74779b8dd9a22a9f58c Cr-Commit-Position: refs/heads/master@{#439527}

Patch Set 1 #

Patch Set 2 : Missed some entries #

Patch Set 3 : git cl formatted #

Patch Set 4 : [Downloads] Add a horizontal material-styled ProgressBar #

Patch Set 5 : Ugh source control #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -13 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java View 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java View 1 2 4 7 chunks +54 lines, -12 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (6 generated)
gone
Helps to send it out for review.
4 years ago (2016-12-16 22:57:21 UTC) #2
gone
Swapping out reviewers for the holiday season.
4 years ago (2016-12-17 01:04:30 UTC) #4
Theresa
lgtm
4 years ago (2016-12-19 17:37:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2577303002/80001
4 years ago (2016-12-19 18:40:55 UTC) #7
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years ago (2016-12-19 19:48:09 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-19 19:51:25 UTC) #12
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/464f8dff920bd0b33f58e74779b8dd9a22a9f58c
Cr-Commit-Position: refs/heads/master@{#439527}

Powered by Google App Engine
This is Rietveld 408576698