Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2577293002:
Change GetIntegerv(IMPLEMENTATION_COLOR_READ_FORMAT/TYPE) behavior. (Closed)
|
Created:
4 years ago by Zhenyao Mo Modified:
4 years ago CC:
chromium-reviews, piman+watch_chromium.org, Kai Ninomiya, ccameron, Justin Novosad, msarett1 Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionChange GetIntegerv(IMPLEMENTATION_COLOR_READ_FORMAT/TYPE) behavior.
1) Clean up a bit mess with framebuffer target
2) On desktop GL, no longer query the driver for these two enums. The drivers
won't provide the answers anyway. Instead, use internal logic to determine
the format/type
BUG=662802
TEST=gpu_unittests,webgl_conformance
R=vmiura@chromium.org,ericrk@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/a11bcfb22a66f56d8a885efd89e7979d60d638b4
Cr-Commit-Position: refs/heads/master@{#439206}
Patch Set 1 #Patch Set 2 : fix #Patch Set 3 : fix #
Depends on Patchset: Messages
Total messages: 29 (17 generated)
Description was changed from ========== Change GetIntegerv(IMPLEMENTATION_COLOR_READ_FORMAT/TYPE) behavior. 1) Clean up a bit mess with framebuffer target 2) On desktop GL, no longer query the driver for these two enums. The drivers won't provide the answers anyway. Instead, use internal logic to determine the format/type BUG=662802 TEST=gpu_unittests,webgl_conformance R=vmiura@chromium.org,ericrk@chromium.org ========== to ========== Change GetIntegerv(IMPLEMENTATION_COLOR_READ_FORMAT/TYPE) behavior. 1) Clean up a bit mess with framebuffer target 2) On desktop GL, no longer query the driver for these two enums. The drivers won't provide the answers anyway. Instead, use internal logic to determine the format/type BUG=662802 TEST=gpu_unittests,webgl_conformance R=vmiura@chromium.org,ericrk@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by zmo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
vmiura: PTAL Others: FYI (feel free to review)
The CQ bit was checked by zmo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm, nice cleanup.
The CQ bit was unchecked by zmo@chromium.org
The CQ bit was checked by zmo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)
Description was changed from ========== Change GetIntegerv(IMPLEMENTATION_COLOR_READ_FORMAT/TYPE) behavior. 1) Clean up a bit mess with framebuffer target 2) On desktop GL, no longer query the driver for these two enums. The drivers won't provide the answers anyway. Instead, use internal logic to determine the format/type BUG=662802 TEST=gpu_unittests,webgl_conformance R=vmiura@chromium.org,ericrk@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Change GetIntegerv(IMPLEMENTATION_COLOR_READ_FORMAT/TYPE) behavior. 1) Clean up a bit mess with framebuffer target 2) On desktop GL, no longer query the driver for these two enums. The drivers won't provide the answers anyway. Instead, use internal logic to determine the format/type BUG=662802 TEST=gpu_unittests,webgl_conformance R=vmiura@chromium.org,ericrk@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
On 2016/12/16 02:52:14, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...) Hmm, that WebglConformance_conformance2_reading_read_pixels_from_fbo_test failure looks real. Did something change with the colorspaces of canvases recently (or similar) that was not run through the optional GPU tryservers?
On 2016/12/16 03:33:46, Ken Russell OOO-till-Dec-19 wrote: > On 2016/12/16 02:52:14, commit-bot: I haz the power wrote: > > Try jobs failed on following builders: > > mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED, > > > http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...) > > Hmm, that WebglConformance_conformance2_reading_read_pixels_from_fbo_test > failure looks real. Did something change with the colorspaces of canvases > recently (or similar) that was not run through the optional GPU tryservers? This is a precision issue. Now we changed to use our own logic to determine the second pair of color read format/type, we expose some new code path. The failure case if for fbo of RGB5_A1 to be read back using (RGBA, UNSIGNED_INT_2_10_10_10_REV). We simply need to increase the error tolerance a little to pass. I need to mark this test as fail on Mac/Linux for this CL to land, and fix the test in conformance and roll in to remove the suppression.
The CQ bit was checked by zmo@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from vmiura@chromium.org Link to the patchset: https://codereview.chromium.org/2577293002/#ps40001 (title: "fix")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
On 2016/12/16 20:03:50, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, > https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...) android failure is flake and irrelevant landing with NOTRY=true
Description was changed from ========== Change GetIntegerv(IMPLEMENTATION_COLOR_READ_FORMAT/TYPE) behavior. 1) Clean up a bit mess with framebuffer target 2) On desktop GL, no longer query the driver for these two enums. The drivers won't provide the answers anyway. Instead, use internal logic to determine the format/type BUG=662802 TEST=gpu_unittests,webgl_conformance R=vmiura@chromium.org,ericrk@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Change GetIntegerv(IMPLEMENTATION_COLOR_READ_FORMAT/TYPE) behavior. 1) Clean up a bit mess with framebuffer target 2) On desktop GL, no longer query the driver for these two enums. The drivers won't provide the answers anyway. Instead, use internal logic to determine the format/type BUG=662802 TEST=gpu_unittests,webgl_conformance R=vmiura@chromium.org,ericrk@chromium.org NOTRY=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by zmo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481925169774090,
"parent_rev": "946d8f6e6592fc3ea1c7b2481aba4140a2485f14", "commit_rev":
"75c2ecea913080f8c040ca8fe3b6978b456a47ab"}
Message was sent while issue was closed.
Description was changed from ========== Change GetIntegerv(IMPLEMENTATION_COLOR_READ_FORMAT/TYPE) behavior. 1) Clean up a bit mess with framebuffer target 2) On desktop GL, no longer query the driver for these two enums. The drivers won't provide the answers anyway. Instead, use internal logic to determine the format/type BUG=662802 TEST=gpu_unittests,webgl_conformance R=vmiura@chromium.org,ericrk@chromium.org NOTRY=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Change GetIntegerv(IMPLEMENTATION_COLOR_READ_FORMAT/TYPE) behavior. 1) Clean up a bit mess with framebuffer target 2) On desktop GL, no longer query the driver for these two enums. The drivers won't provide the answers anyway. Instead, use internal logic to determine the format/type BUG=662802 TEST=gpu_unittests,webgl_conformance R=vmiura@chromium.org,ericrk@chromium.org NOTRY=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2577293002 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Change GetIntegerv(IMPLEMENTATION_COLOR_READ_FORMAT/TYPE) behavior. 1) Clean up a bit mess with framebuffer target 2) On desktop GL, no longer query the driver for these two enums. The drivers won't provide the answers anyway. Instead, use internal logic to determine the format/type BUG=662802 TEST=gpu_unittests,webgl_conformance R=vmiura@chromium.org,ericrk@chromium.org NOTRY=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2577293002 ========== to ========== Change GetIntegerv(IMPLEMENTATION_COLOR_READ_FORMAT/TYPE) behavior. 1) Clean up a bit mess with framebuffer target 2) On desktop GL, no longer query the driver for these two enums. The drivers won't provide the answers anyway. Instead, use internal logic to determine the format/type BUG=662802 TEST=gpu_unittests,webgl_conformance R=vmiura@chromium.org,ericrk@chromium.org NOTRY=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/a11bcfb22a66f56d8a885efd89e7979d60d638b4 Cr-Commit-Position: refs/heads/master@{#439206} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/a11bcfb22a66f56d8a885efd89e7979d60d638b4 Cr-Commit-Position: refs/heads/master@{#439206} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
