Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Issue 2577143002: [runtime] Add PositiveNumberToUint32 helper to avoid double to uint roundtrip (Closed)

Created:
4 years ago by Camillo Bruni
Modified:
4 years ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Add PositiveNumberToUint32 helper to avoid double to uint roundtrip BUG= Review-Url: https://codereview.chromium.org/2577143002 Cr-Commit-Position: refs/heads/master@{#41801} Committed: https://chromium.googlesource.com/v8/v8/+/1c1465f12483354daf4400d4080465a6bef7b693

Patch Set 1 #

Patch Set 2 : use PositiveNumberToUint32 in regexp #

Patch Set 3 : adding cctests #

Patch Set 4 : add missing uint32_t cast #

Patch Set 5 : avoid overflows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -35 lines) Patch
M src/builtins/builtins-string.cc View 3 chunks +4 lines, -11 lines 0 comments Download
M src/conversions.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/conversions-inl.h View 1 1 chunk +15 lines, -1 line 0 comments Download
M src/objects.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.cc View 2 chunks +4 lines, -10 lines 0 comments Download
M src/objects-inl.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/runtime/runtime-regexp.cc View 1 8 chunks +11 lines, -13 lines 0 comments Download
M test/cctest/test-conversions.cc View 1 2 3 4 1 chunk +46 lines, -0 lines 0 comments Download
M test/mjsunit/es6/string-startswith.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 21 (17 generated)
Camillo Bruni
PTAL
4 years ago (2016-12-19 09:06:10 UTC) #8
jgruber
Nice, lgtm
4 years ago (2016-12-19 09:26:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2577143002/80001
4 years ago (2016-12-19 11:35:50 UTC) #18
commit-bot: I haz the power
4 years ago (2016-12-19 12:07:08 UTC) #21
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/1c1465f12483354daf4400d4080465a6bef...

Powered by Google App Engine
This is Rietveld 408576698