src/conversions.h - Issue 2577143002: [runtime] Add PositiveNumberToUint32 helper to avoid double to uint roundtrip

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/conversions.h

Issue 2577143002: [runtime] Add PositiveNumberToUint32 helper to avoid double to uint roundtrip (Closed)

Patch Set: avoid overflows Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/conversions.h

diff --git a/src/conversions.h b/src/conversions.h

index 2dd91d93190c0936b9358f7ca0a4a22d7e9faba3..0472da89007eaebc0db108fcbc591dc55ee6bfd0 100644

--- a/src/conversions.h

+++ b/src/conversions.h

@@ -168,6 +168,7 @@ inline bool IsInt32Double(double value);

inline bool IsUint32Double(double value);

// Convert from Number object to C integer.

+inline uint32_t PositiveNumberToUint32(Object* number);

inline int32_t NumberToInt32(Object* number);

inline uint32_t NumberToUint32(Object* number);

inline int64_t NumberToInt64(Object* number);

« no previous file with comments | « src/builtins/builtins-string.cc ('k') | src/conversions-inl.h » ('j') | no next file with comments »