Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 2577063002: Reland of "Store SharedFunctionInfos of a Script in a FixedArray indexed by their ID" (Closed)

Created:
4 years ago by jochen (gone - plz use gerrit)
Modified:
4 years ago
Reviewers:
Toon Verwaest, jgruber
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of "Store SharedFunctionInfos of a Script in a FixedArray indexed by their ID" Original CL description: > Store SharedFunctionInfos of a Script in a FixedArray indexed by their ID > > Now that SharedFunctionInfos have a unique ID (and the IDs are dense), > we can use them as an index into an array, instead of using a > WeakFixedArray where we have to do a linear scan. > > Hooking up liveedit is a bit more involved, see > https://docs.google.com/presentation/d/1FtNa3U7WsF5bPhY9uGoJG5Y9hnz5VBDabfOWpb4unWI/edit > for an overview > > BUG=v8:5589 > R=verwaest@chromium.org,jgruber@chromium.org > > Review-Url: https://codereview.chromium.org/2547483002 BUG=v8:5589 TBR=verwaest@chromium.org,jgruber@chromium.org Review-Url: https://codereview.chromium.org/2577063002 Cr-Commit-Position: refs/heads/master@{#41734} Committed: https://chromium.googlesource.com/v8/v8/+/4f2cb8fe829ea84eb4920a7e3ec30bd9f3f5e7e6

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+255 lines, -154 lines) Patch
M src/bootstrapper.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler.cc View 6 chunks +24 lines, -16 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/debug/debug.cc View 3 chunks +14 lines, -21 lines 0 comments Download
M src/debug/liveedit.h View 3 chunks +7 lines, -3 lines 0 comments Download
M src/debug/liveedit.cc View 7 chunks +33 lines, -13 lines 0 comments Download
M src/debug/liveedit.js View 1 7 chunks +25 lines, -12 lines 0 comments Download
M src/factory.cc View 2 chunks +1 line, -2 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/heap/object-stats.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/js/promise.js View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 6 chunks +26 lines, -13 lines 0 comments Download
M src/objects.cc View 3 chunks +74 lines, -49 lines 0 comments Download
M src/objects-inl.h View 3 chunks +1 line, -5 lines 0 comments Download
M src/parsing/parse-info.h View 2 chunks +6 lines, -0 lines 0 comments Download
M src/parsing/parse-info.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/parsing/parser.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-function.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M src/runtime/runtime-liveedit.cc View 1 chunk +18 lines, -2 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/parsing/test-parse-decision.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/unittests/compiler-dispatcher/compiler-dispatcher-job-unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2577063002/20001
4 years ago (2016-12-15 16:24:50 UTC) #2
commit-bot: I haz the power
4 years ago (2016-12-15 17:20:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/4f2cb8fe829ea84eb4920a7e3ec30bd9f3f...

Powered by Google App Engine
This is Rietveld 408576698